interpret: add read_machine_[ui]size convenience methods #105602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ rollup yea, I've also been wondering about |
|
Those are a bit less noisy due to not needing data layout access. But yeah we could have the entire suite of methods that we also have on |
|
@bors ping None of the bots has reacted in this PR yet? There's no PR CI either. https://www.githubstatus.com/ is all green but I feel like that's just not reflecting the actual status... |
|
@bors r=oli-obk |
bors
added
the
S-waiting-on-bors
fee1-dead
added a commit
to fee1-dead-contrib/rust
that referenced
this pull request
Dec 21, 2022
interpret: add read_machine_[ui]size convenience methods We have `read_pointer`, so it felt inconsistent to not also have these. r? `@oli-obk`
fee1-dead
added a commit
to fee1-dead-contrib/rust
that referenced
this pull request
Dec 21, 2022
interpret: add read_machine_[ui]size convenience methods We have `read_pointer`, so it felt inconsistent to not also have these. r? ``@oli-obk``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 22, 2022
Rollup of 8 pull requests Successful merges: - rust-lang#105584 (add assert messages if chunks/windows are length 0) - rust-lang#105602 (interpret: add read_machine_[ui]size convenience methods) - rust-lang#105824 (str.lines() docstring: clarify that line endings are not returned) - rust-lang#105980 (Refer to "Waker" rather than "RawWaker" in `drop` comment) - rust-lang#105986 (Fix typo in reading_half_a_pointer.rs) - rust-lang#105995 (Add regression test for rust-lang#96530) - rust-lang#106008 (Sort lint_groups in no_lint_suggestion) - rust-lang#106014 (Add comment explaining what the scrape-examples-toggle.goml GUI test is about) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Aaron1011
pushed a commit
to Aaron1011/rust
that referenced
this pull request
Jan 6, 2023
interpret: add read_machine_[ui]size convenience methods We have `read_pointer`, so it felt inconsistent to not also have these. r? ```@oli-obk```
Aaron1011
pushed a commit
to Aaron1011/rust
that referenced
this pull request
Jan 6, 2023
Rollup of 8 pull requests Successful merges: - rust-lang#105584 (add assert messages if chunks/windows are length 0) - rust-lang#105602 (interpret: add read_machine_[ui]size convenience methods) - rust-lang#105824 (str.lines() docstring: clarify that line endings are not returned) - rust-lang#105980 (Refer to "Waker" rather than "RawWaker" in `drop` comment) - rust-lang#105986 (Fix typo in reading_half_a_pointer.rs) - rust-lang#105995 (Add regression test for rust-lang#96530) - rust-lang#106008 (Sort lint_groups in no_lint_suggestion) - rust-lang#106014 (Add comment explaining what the scrape-examples-toggle.goml GUI test is about) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have
read_pointer, so it felt inconsistent to not also have these.r? @oli-obk