Fix ICE calling method on auto trait #105747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
| @@ -688,7 +688,12 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> { | |||
| let entry = spanned_predicates.entry(spans); | |||
| entry.or_insert_with(|| (path, tr_self_ty, Vec::new())).2.push(p); | |||
| } | |||
| Some(_) => unreachable!(), | |||
| Some(_node) => { | |||
There was a problem hiding this comment.
I'm not sure if we should make this a bit more specific matching against auto traits...
chenyukang
force-pushed
the
yukang/fix-105732-auto-trait
branch
from
2afc40e to
605f77b
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 16, 2022
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#105725 (Allow `impl ~const Trait` opaque types) - rust-lang#105744 (Rewrite `E0158` error-code docs for clarity) - rust-lang#105747 (Fix ICE calling method on auto trait) - rust-lang#105748 (doc: Fix a few small issues) - rust-lang#105756 (rustdoc: simplify CSS for codeblock tooltips) - rust-lang#105757 (rustdoc: remove unused CSS `.sub-settings`) - rust-lang#105764 (rustdoc: name the source page sidebar-toggle `#src-sidebar-toggle`) - rust-lang#105774 (Remove unused stderr files) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #105732
r? @compiler-errors