Refactoring report_method_error

[chenyukang]

While working on #105732, I found it's hard to follow this long function,
so I tried to make it shorter.

It's not easy for code reviewing, since so many lines of code changes,
but only the positions are changed.

Generally, I extract two sub-methods from report_method_error:

rust/compiler/rustc_hir_typeck/src/method/suggest.rs

Line 117 in 397b66e

let report_candidates = |span: Span,

to note_candidates_on_method_error

And this long block:

rust/compiler/rustc_hir_typeck/src/method/suggest.rs

Line 263 in 397b66e

MethodError::NoMatch(NoMatchData {

to report_no_match_method_error.

r? @compiler-errors

[bors]

☔ The latest upstream changes (presumably #105746) made this pull request unmergeable. Please resolve the merge conflicts.

[compiler-errors]

This could use a rebase. I'll approve after that.

[chenyukang]

@rustbot ready

[bors]

☔ The latest upstream changes (presumably #84762) made this pull request unmergeable. Please resolve the merge conflicts.

[chenyukang]

emmm, conflict again...
@rustbot ready

[compiler-errors]

@bors r+

[bors]

📌 Commit 93e62a4 has been approved by compiler-errors

It is now in the queue for this repository.

[bors]

⌛ Testing commit 93e62a4 with merge c757267...

[bors]

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing c757267 to master...

[rust-timer]

Finished benchmarking commit (c757267): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.6%	[-2.6%, -2.6%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.6%	[-2.6%, -2.6%]	1

Cycles

This benchmark run did not return any relevant results for this metric.