Skip to content

Make enum-match.rs test robust against variable name changes #105802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2022

Conversation

chbaker0
Copy link
Contributor

https://reviews.llvm.org/D140192 caused the LLVM variable generated for enum discriminant checks to be named differently (%narrow vs %1).

This adjusts the test CHECK directives to match any name.

https://reviews.llvm.org/D140192 caused the LLVM variable generated
for enum discriminant checks to be named differently (%narrow vs %1).

This adjusts the test CHECK directives to match any name.
@rustbot
Copy link
Collaborator

rustbot commented Dec 16, 2022

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 16, 2022
@chbaker0
Copy link
Contributor Author

@rustbot label +A-LLVM

@rustbot rustbot added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label Dec 16, 2022
@tmiasko
Copy link
Contributor

tmiasko commented Dec 16, 2022

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 16, 2022

📌 Commit 8751d3b has been approved by tmiasko

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 16, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 17, 2022
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#105493 (Help rust-analyzer normalize query return types)
 - rust-lang#105710 (Don't bug if we're trying to cast `dyn*` to another type)
 - rust-lang#105711 (bail in `collect_trait_impl_trait_tys` if signatures reference errors)
 - rust-lang#105768 (Detect inherent associated types not having CamelCase)
 - rust-lang#105780 (rustdoc: Don't add "Read more" link if there is no extra content)
 - rust-lang#105802 (Make enum-match.rs test robust against variable name changes)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 803ce45 into rust-lang:master Dec 17, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants