Suggest a T: Send bound for &mut T upvars in Send generators
#105839
Merged
+103
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @lcnr (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 19, 2022
Rollup of 5 pull requests Successful merges: - rust-lang#105682 (Use `expose_addr()` in `fmt::Pointer`) - rust-lang#105839 (Suggest a `T: Send` bound for `&mut T` upvars in `Send` generators) - rust-lang#105864 (clippy::complexity fixes) - rust-lang#105882 (Don't ICE in closure arg borrow suggestion) - rust-lang#105889 (Fix `uninlined_format_args` in libtest) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, we suggest a
T: Syncbound for both&Tand&mut Tupvars. A user on URLO found this confusing, so I wrote this quick fix to look at the mutability before making the suggestion.