Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[perf only] Test function specialization #105956

Closed
wants to merge 4 commits into from
Closed

Conversation

nikic
Copy link
Contributor

@nikic nikic commented Dec 20, 2022

r? @ghost

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 20, 2022
@nikic
Copy link
Contributor Author

nikic commented Dec 20, 2022

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 20, 2022
@bors
Copy link
Collaborator

bors commented Dec 20, 2022

⌛ Trying commit b4eef9bb78ce1a5d5ff713eb931b5fc474ae9ddc with merge 42f15a888b84383660493ba571b9d8262d73681a...

@bors
Copy link
Collaborator

bors commented Dec 20, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 20, 2022
LLVM does this itself since 606cb85,
and 14 is no longer the correct standard when building lld 16,
causing build failures.
@rust-log-analyzer

This comment has been minimized.

@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Dec 20, 2022
@nikic
Copy link
Contributor Author

nikic commented Dec 20, 2022

LLD build still fails -- it looks like the llvm-driver-template.cpp.in export doesn't work for some reason.

LLVM_CONFIG_PATH is no longer supported.
@nikic
Copy link
Contributor Author

nikic commented Dec 21, 2022

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@bors
Copy link
Collaborator

bors commented Dec 21, 2022

⌛ Trying commit 2c81171 with merge 70212127e0974013f7e031861d421356e85b0e27...

@bors
Copy link
Collaborator

bors commented Dec 21, 2022

☀️ Try build successful - checks-actions
Build commit: 70212127e0974013f7e031861d421356e85b0e27 (70212127e0974013f7e031861d421356e85b0e27)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (70212127e0974013f7e031861d421356e85b0e27): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.9% [0.2%, 2.8%] 67
Regressions ❌
(secondary)
0.9% [0.2%, 2.7%] 27
Improvements ✅
(primary)
-0.8% [-4.9%, -0.2%] 61
Improvements ✅
(secondary)
-1.0% [-5.6%, -0.3%] 78
All ❌✅ (primary) 0.1% [-4.9%, 2.8%] 128

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.3% [0.8%, 3.6%] 10
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.0% [-3.9%, -0.1%] 2
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.6% [-3.9%, 3.6%] 12

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.0% [1.1%, 2.7%] 11
Regressions ❌
(secondary)
2.2% [2.1%, 2.4%] 2
Improvements ✅
(primary)
-2.0% [-4.0%, -1.2%] 98
Improvements ✅
(secondary)
-2.9% [-6.9%, -0.8%] 51
All ❌✅ (primary) -1.6% [-4.0%, 2.7%] 109

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Dec 21, 2022
@nikic
Copy link
Contributor Author

nikic commented Dec 21, 2022

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 21, 2022
@bors
Copy link
Collaborator

bors commented Dec 21, 2022

⌛ Trying commit 228430a with merge 413335368bf860e701f6365b0f2f0fa4d7f85b9a...

@bors
Copy link
Collaborator

bors commented Dec 21, 2022

☀️ Try build successful - checks-actions
Build commit: 413335368bf860e701f6365b0f2f0fa4d7f85b9a (413335368bf860e701f6365b0f2f0fa4d7f85b9a)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (413335368bf860e701f6365b0f2f0fa4d7f85b9a): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.9% [0.2%, 2.6%] 71
Regressions ❌
(secondary)
0.9% [0.2%, 2.8%] 27
Improvements ✅
(primary)
-0.9% [-5.2%, -0.2%] 64
Improvements ✅
(secondary)
-1.0% [-5.6%, -0.2%] 82
All ❌✅ (primary) 0.0% [-5.2%, 2.6%] 135

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.8% [1.4%, 2.1%] 5
Regressions ❌
(secondary)
1.5% [1.5%, 1.5%] 1
Improvements ✅
(primary)
-1.8% [-3.5%, -0.1%] 2
Improvements ✅
(secondary)
-1.6% [-1.6%, -1.6%] 2
All ❌✅ (primary) 0.7% [-3.5%, 2.1%] 7

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.8% [1.2%, 2.5%] 14
Regressions ❌
(secondary)
2.3% [2.2%, 2.4%] 2
Improvements ✅
(primary)
-2.0% [-4.1%, -1.2%] 91
Improvements ✅
(secondary)
-3.1% [-7.7%, -1.0%] 54
All ❌✅ (primary) -1.5% [-4.1%, 2.5%] 105

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 21, 2022
@nikic
Copy link
Contributor Author

nikic commented Dec 21, 2022

@nikic nikic closed this Dec 21, 2022
@nikic nikic mentioned this pull request Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf-regression Performance regression. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants