Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc: Remove needless lifetimes #105975

Merged
merged 4 commits into from
Dec 24, 2022
Merged

rustc: Remove needless lifetimes #105975

merged 4 commits into from
Dec 24, 2022

Conversation

jeremystucki
Copy link
Contributor

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Dec 20, 2022

r? @eholk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 20, 2022
@rustbot
Copy link
Collaborator

rustbot commented Dec 20, 2022

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

These commits modify compiler targets.
(See the Target Tier Policy.)

Some changes occured in rustc_ty_utils::consts.rs

cc @BoxyUwU

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

rustc_macros::diagnostics was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo

jyn514
jyn514 reviewed Dec 20, 2022
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only skimmed this, but in general it seems reasonable. Can you also remove allow(unused_lifetimes) wherever possible?

compiler/rustc_graphviz/src/lib.rs Outdated Show resolved Hide resolved
eholk
eholk approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@eholk eholk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'd prefer the graphviz file to have LayoutText<'_> as the return type, but then feel free to r=me.

@jeremystucki
Copy link
Contributor Author

@bors r=eholk

@bors
Copy link
Contributor

bors commented Dec 23, 2022

@jeremystucki: 🔑 Insufficient privileges: Not in reviewers

@jeremystucki
Copy link
Contributor Author

@eholk I'm not quite sure what you meant by feel free to r=me.

I updated the graphviz file to indicate the inferred lifetime.

@jyn514 jyn514 mentioned this pull request Dec 23, 2022
Closed
@jyn514
Copy link
Member

jyn514 commented Dec 23, 2022

@bors r=eholk

@bors
Copy link
Contributor

bors commented Dec 23, 2022

📌 Commit 1174aac has been approved by eholk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 23, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 23, 2022
@matthiaskrgr
Rollup merge of rust-lang#105975 - jeremystucki:rustc-remove-needless…
06d351c 
…-lifetimes, r=eholk

rustc: Remove needless lifetimes
This was referenced Dec 23, 2022
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 24, 2022
@bors
Auto merge of rust-lang#106103 - matthiaskrgr:rollup-8xe9ddz, r=matth…
6c0c6d6 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#105970 (docs/test: add UI test and long-form error docs for E0462)
 - rust-lang#105975 (rustc: Remove needless lifetimes)
 - rust-lang#106069 (rustdoc: use a more evocative name for CSS/JS `#titles`)
 - rust-lang#106084 (fix vec::IntoIter::drop on high-alignment ZST)
 - rust-lang#106091 (Use correct CSS pseudo-element selector)
 - rust-lang#106093 (rustdoc: remove no-op CSS from `.docblock-short`)
 - rust-lang#106102 (Fix `triagebot.toml`)

Failed merges:

 - rust-lang#106028 (docs/test: add UI test and long-form error docs for `E0461`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d23cb73 into rust-lang:master Dec 24, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 24, 2022
@jeremystucki jeremystucki deleted the rustc-remove-needless-lifetimes branch December 24, 2022 13:38
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@matthiaskrgr
Rollup merge of rust-lang#105975 - jeremystucki:rustc-remove-needless…
a7e05f6 
…-lifetimes, r=eholk

rustc: Remove needless lifetimes
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@bors
Auto merge of rust-lang#106103 - matthiaskrgr:rollup-8xe9ddz, r=matth…
3c5198d 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#105970 (docs/test: add UI test and long-form error docs for E0462)
 - rust-lang#105975 (rustc: Remove needless lifetimes)
 - rust-lang#106069 (rustdoc: use a more evocative name for CSS/JS `#titles`)
 - rust-lang#106084 (fix vec::IntoIter::drop on high-alignment ZST)
 - rust-lang#106091 (Use correct CSS pseudo-element selector)
 - rust-lang#106093 (rustdoc: remove no-op CSS from `.docblock-short`)
 - rust-lang#106102 (Fix `triagebot.toml`)

Failed merges:

 - rust-lang#106028 (docs/test: add UI test and long-form error docs for `E0461`)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 left review comments

@compiler-errors compiler-errors compiler-errors left review comments

@oli-obk oli-obk oli-obk left review comments

@eholk eholk eholk approved these changes

Assignees

@eholk eholk

Labels
A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
7 participants
@jeremystucki @rustbot @bors @jyn514 @eholk @oli-obk @compiler-errors