Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Const closures #106004

Merged
merged 8 commits into from
Jan 13, 2023
Merged

Const closures #106004

merged 8 commits into from
Jan 13, 2023

Conversation

fee1-dead
Copy link
Member

@fee1-dead fee1-dead commented Dec 21, 2022

cc #106003

@rustbot
Copy link
Collaborator

rustbot commented Dec 21, 2022

r? @lcnr

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 21, 2022
@rust-log-analyzer

This comment has been minimized.

@lcnr
Copy link
Contributor

lcnr commented Dec 21, 2022

r? @oli-obk

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@fee1-dead fee1-dead marked this pull request as ready for review December 26, 2022 16:26
@rustbot
Copy link
Collaborator

rustbot commented Dec 26, 2022

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@bors
Copy link
Contributor

bors commented Dec 30, 2022

☔ The latest upstream changes (presumably #106210) made this pull request unmergeable. Please resolve the merge conflicts.

@oli-obk
Copy link
Contributor

oli-obk commented Jan 9, 2023

This impl lgtm and does not unduely complicate my effects generics PR, so r=me after a rebase

@fee1-dead
Copy link
Member Author

@bors r=oli-obk

@bors
Copy link
Contributor

bors commented Jan 9, 2023

📌 Commit adcea57190451565345b19f58da3cf9e024b79bd has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 9, 2023
@dtolnay
Copy link
Member

dtolnay commented Jan 11, 2023

This needs to be rebased past #106458 because it is showing not mergeable in bors.
https://bors.rust-lang.org/queue/rust
@bors r-
@rustbot author

@fee1-dead
Copy link
Member Author

@bors r=oli-obk

@bors
Copy link
Contributor

bors commented Jan 12, 2023

📌 Commit ca1eb43 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 12, 2023
@fee1-dead
Copy link
Member Author

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 12, 2023
@oli-obk
Copy link
Contributor

oli-obk commented Jan 12, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Jan 12, 2023

📌 Commit 42a50ba has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 12, 2023
@klensy
Copy link
Contributor

klensy commented Jan 12, 2023

Link to #106003 in description would be nice.

@bors
Copy link
Contributor

bors commented Jan 13, 2023

⌛ Testing commit 42a50ba with merge 279f1c9...

@bors
Copy link
Contributor

bors commented Jan 13, 2023

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 279f1c9 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 13, 2023
@bors bors merged commit 279f1c9 into rust-lang:master Jan 13, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 13, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (279f1c9): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.9% [0.2%, 1.6%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.3% [3.3%, 3.3%] 1
Regressions ❌
(secondary)
1.6% [1.1%, 2.1%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.7% [-1.7%, -1.7%] 2
All ❌✅ (primary) 3.3% [3.3%, 3.3%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

onestacked added a commit to ink-feather-org/rust-analyzer that referenced this pull request Jan 19, 2023
Enables parsing of the syntax for `#![features(const_closures)]` introduced in rust-lang/rust#106004
onestacked added a commit to ink-feather-org/rust-analyzer that referenced this pull request Jan 19, 2023
Enables parsing of the syntax for `#![features(const_closures)]` introduced in rust-lang/rust#106004
onestacked added a commit to ink-feather-org/rust-analyzer that referenced this pull request Jan 19, 2023
Enables parsing of the syntax for `#![features(const_closures)]` introduced in rust-lang/rust#106004
bors added a commit to rust-lang/rust-analyzer that referenced this pull request Jan 19, 2023
Parse const_closures syntax.

Enables parsing of the syntax for `#![features(const_closures)]` introduced in [this PR](rust-lang/rust#106004)
@fee1-dead fee1-dead deleted the const-closures branch January 20, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants