Skip to content

Conversation

@kadiwa4
Copy link
Contributor

@kadiwa4 kadiwa4 commented Dec 24, 2022

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Dec 24, 2022

r? @Nilstrieb

(rustbot has picked a reviewer for you, use r? to override)

@rustbot
Copy link
Collaborator

rustbot commented Dec 24, 2022

These commits modify compiler targets.
(See the Target Tier Policy.)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 24, 2022
@compiler-errors
Copy link
Member

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 25, 2022

📌 Commit 7b371d2 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 25, 2022
@bors
Copy link
Collaborator

bors commented Dec 25, 2022

⌛ Testing commit 7b371d2 with merge 40d7940...

@bors
Copy link
Collaborator

bors commented Dec 25, 2022

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 40d7940 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 25, 2022
@bors bors merged commit 40d7940 into rust-lang:master Dec 25, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 25, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (40d7940): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.1% [-1.1%, -1.1%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.5% [2.5%, 2.5%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.5% [2.5%, 2.5%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

@kadiwa4 kadiwa4 deleted the typos branch December 25, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants