Collect and emit proper backtraces for delay_span_bug
s
#106321
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #106317, which addresses this comment (#106267 (comment)) which notes that
delay_span_bug
s' backtraces are nonsense.Captures and emits the backtrace of the delayed span bug when it's created, rather than using the backtrace of the place where delayed bugs are flushed.
To test, I delayed a span bug during HIR typeck, specifically in
typeck_with_fallback
...Before, note
flush_delayed
on frame 18. This is at the end of the compilation session, far from where the bug is being delayed.After, note
typeck_with_fallback
on the 5th frame, that's where we actually need to be pointed to: