Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #106386

Merged
merged 24 commits into from
Jan 3, 2023
Merged

Commits on Dec 30, 2022

  1. Add notes and examples about non-intuitive PathBuf::set_extension b…

    …ehavior
    
    Basically, passing the empty string will actually remove the extension
    instead of setting it to the empty string. This might change what is
    considered to be an extension. Additionally, passing an extension that
    contains dots will make the path only consider the last part of it to be
    the new extension.
    tbu- committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    40916ef View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2023

  1. Configuration menu
    Copy the full SHA
    b7b252a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cca5d21 View commit details
    Browse the repository at this point in the history
  3. Cleanup mingw-tidy docker job

    - Avoid `/checkout/src/ci/run.sh: line 187: [: =: unary operator expected`: https://github.com/rust-lang/rust/actions/runs/3809902408/jobs/6481611301#step:26:1701
    - Avoid running `x check` in the tidy test, to get faster feedback. It's
      already run on the normal `mingw-check` job.
    jyn514 committed Jan 1, 2023
    Configuration menu
    Copy the full SHA
    beefcf8 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2023

  1. Configuration menu
    Copy the full SHA
    3919b71 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e885356 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ed3c3d3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1a94322 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a167435 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c156773 View commit details
    Browse the repository at this point in the history
  7. Update books

    rustbot committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    693399f View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    fd59b62 View commit details
    Browse the repository at this point in the history
  9. Remove test of static Context

    Context is no longer Sync so this doesn't work.
    
        error[E0277]: `*mut ()` cannot be shared between threads safely
          --> library/core/tests/task.rs:24:21
           |
        24 |     static CONTEXT: Context<'static> = Context::from_waker(&WAKER);
           |                     ^^^^^^^^^^^^^^^^ `*mut ()` cannot be shared between threads safely
           |
           = help: within `Context<'static>`, the trait `Sync` is not implemented for `*mut ()`
           = note: required because it appears within the type `PhantomData<*mut ()>`
           = note: required because it appears within the type `Context<'static>`
           = note: shared static variables must have a type that implements `Sync`
    dtolnay committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    257e766 View commit details
    Browse the repository at this point in the history
  10. Reduce HIR debug output

    HIR debug output is currently very verbose, especially when used with
    the alternate (`#`) flag. This commit reduces the amount of noisy
    newlines by forcing a few small key types to stay on one line, which
    makes the output easier to read and scroll by.
    
    ```
    $ rustc +after hello_world.rs -Zunpretty=hir-tree | wc -l
    582
    $ rustc +before hello_world.rs -Zunpretty=hir-tree | wc -l
    932
    ```
    Noratrieb committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    e1787f5 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    3c7c694 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    157211f View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#95985 - jihiggins:issue-66481, r=dtolnay

    Add PhantomData marker to Context to make Context !Send and !Sync
    
    Adds `PhantomData<*mut ()>` to `Context` in order to allow for future `!Send` or `!Sync` additions to `Context`'s fields. This would allow for things like future single threaded async executor optimizations, or (re)adding `LocalWaker`, etc.
    
    Closes rust-lang#66481.
    
    Per rust-lang#66481 (comment), this is a breaking change that needs a Crater run as the next step.
    
    (So far have tested the change locally with `cargotest` on WSL)
    compiler-errors authored Jan 2, 2023
    Configuration menu
    Copy the full SHA
    722bc0c View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#104298 - tbu-:pr_set_extension_caveats, r=m…

    …-ou-se
    
    Add notes and examples about non-intuitive `PathBuf::set_extension` behavior
    
    Basically, passing the empty string will actually remove the extension instead of setting it to the empty string. This might change what is considered to be an extension. Additionally, passing an extension that contains dots will make the path only consider the last part of it to be the new extension.
    compiler-errors authored Jan 2, 2023
    Configuration menu
    Copy the full SHA
    da1ca5d View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#105558 - Nilstrieb:less-spam-hir-tree, r=cj…

    …gillot
    
    Reduce HIR debug output
    
    HIR debug output is currently very verbose, especially when used with the alternate (`#`) flag. This commit reduces the amount of noisy newlines by forcing a few small key types to stay on one line, which makes the output easier to read and scroll by.
    
    ```
    $ rustc +after hello_world.rs -Zunpretty=hir-tree | wc -l
    582
    $ rustc +before hello_world.rs -Zunpretty=hir-tree | wc -l
    932
    ```
    compiler-errors authored Jan 2, 2023
    Configuration menu
    Copy the full SHA
    fbffaa9 View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#106315 - jyn514:cleanup-mingw-tidy, r=fee1-…

    …dead
    
    Cleanup `mingw-tidy` docker job
    
    Fixes a couple small regressions from rust-lang#106048 and rust-lang#105714.
    
    - Avoid `/checkout/src/ci/run.sh: line 187: [: =: unary operator expected`: https://github.com/rust-lang/rust/actions/runs/3809902408/jobs/6481611301#step:26:1701
    - Avoid running `x check` in the tidy test, to get faster feedback. It's already run on the normal `mingw-check` job.
    
    r? `@fee1-dead`
    compiler-errors authored Jan 2, 2023
    Configuration menu
    Copy the full SHA
    0670a61 View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#106354 - aDotInTheVoid:rdj-always-discr, r=…

    …GuillaumeGomez
    
    Rustdoc-Json: Report discriminant on all kinds of enum variant.
    
    Closes rust-lang#106299
    
    Probably easier to review one commit at a time.
    
    r? `@GuillaumeGomez`
    compiler-errors authored Jan 2, 2023
    Configuration menu
    Copy the full SHA
    0d5c5fa View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#106366 - GuillaumeGomez:fix-rustdoc-ice-typ…

    …edef-type-mismatch, r=notriddle
    
    Fix rustdoc ICE on bad typedef with mismatching types
    
    Fixes rust-lang#106226.
    Fixes rust-lang#105742.
    Fixes rust-lang#105737.
    Fixes rust-lang#105334.
    Fixes rust-lang#96287.
    
    In this case, it's ok to replace the panic with `rustc_error::raise` because the compiler provided us with a `Error`.
    
    r? `@notriddle`
    compiler-errors authored Jan 2, 2023
    Configuration menu
    Copy the full SHA
    ea3c4d8 View commit details
    Browse the repository at this point in the history
  19. Rollup merge of rust-lang#106376 - rustbot:docs-update, r=ehuss

    Update books
    
    ## rust-lang/book
    
    3 commits in a60f4316ec923a5ac2ed6a2eba6960edb832d855..2bd5d42c9956369132228da6409f0e68da56c51a
    2022-12-22 21:37:10 UTC to 2022-12-22 21:36:14 UTC
    
    - fix macos installation problem (rust-lang/book#3469)
    - Update -guessing-game-tutorial incorrect output (rust-lang/book#3462)
    - FIX: IT repo updated (rust-lang/book#3454)
    
    ## rust-lang/nomicon
    
    1 commits in dd37e21ccee43918ed18a71581bb2af537ffe4fc..8ca261268068d80c0969260fff15199bad87b587
    2022-12-30 16:32:09 UTC to 2022-12-30 16:32:09 UTC
    
    - Discourage the use of transmute to construct invalid values (rust-lang/nomicon#388)
    
    ## rust-lang/rust-by-example
    
    6 commits in 995df09b65c582eb6290ab7ea5d9485983eb4c37..8888f9428fe9a48f31de6bd2cef9b9bf80791edc
    2023-01-01 12:53:50 UTC to 2022-12-21 10:18:31 UTC
    
    - types/alias: use io::{Result,Error} instead of Io{Result,Error} (rust-lang/rust-by-example#1660)
    - Fix sample code mismatching its comments (rust-lang/rust-by-example#1659)
    - fix: add missing space (rust-lang/rust-by-example#1658)
    - diverging: fix issues with example code (rust-lang/rust-by-example#1631)
    - Update enum.md (rust-lang/rust-by-example#1645)
    - Clean up Chapter 2 (Primitives) (rust-lang/rust-by-example#1651)
    
    ## rust-lang/rustc-dev-guide
    
    5 commits in 8b42eb5f57d3d8ed2257a22d0e850d9db52afed3..b3e2a6e6c8a3aae5b5d950c63046f23bae07096d
    2023-01-01 05:20:47 UTC to 2022-12-25 12:11:21 UTC
    
    - Add help for when you update a submodule by accident (rust-lang/rustc-dev-guide#1537)
    - Simplify "how to build and run" section (rust-lang/rustc-dev-guide#1528)
    - Replace `$TARGET` with `host` (rust-lang/rustc-dev-guide#1514)
    - Add more rebasing help (rust-lang/rustc-dev-guide#1536)
    - Fix rustc_borrowck crate name typo (rust-lang/rustc-dev-guide#1535)
    compiler-errors authored Jan 2, 2023
    Configuration menu
    Copy the full SHA
    d112cd9 View commit details
    Browse the repository at this point in the history
  20. Rollup merge of rust-lang#106383 - Manishearth:ast-docs, r=compiler-e…

    …rrors
    
    Document some of the AST nodes
    
    Someone was confused about some of this on Zulip, added some docs
    
    We probably should make sure every last field/variant in the AST/HIR is documented at some point
    
    `@bors` rollup
    compiler-errors authored Jan 2, 2023
    Configuration menu
    Copy the full SHA
    d4cf00f View commit details
    Browse the repository at this point in the history