Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoVec MVP 2 #106467

Closed
wants to merge 47 commits into from
Closed

CoVec MVP 2 #106467

wants to merge 47 commits into from

Conversation

peter-lyons-kehl
Copy link
Contributor

@peter-lyons-kehl peter-lyons-kehl commented Jan 4, 2023

IGNORE (until further notice). My early WIP.

Currently it triggers an ICE #105573 (dealt with separately).

For now this draft PR uses Rust CI to build code that triggers #105573. (As per https://rustc-dev-guide.rust-lang.org/contributing.html#ci: "perfectly fine (and even encouraged!) to use the CI to test your changes if it can help your productivity").

@rustbot
Copy link
Collaborator

rustbot commented Jan 4, 2023

r? @joshtriplett

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jan 4, 2023
@peter-lyons-kehl
Copy link
Contributor Author

r? peter-kehl

@rust-log-analyzer

This comment has been minimized.

@peter-lyons-kehl peter-lyons-kehl mentioned this pull request Jan 4, 2023
@peter-lyons-kehl peter-lyons-kehl changed the title Vec mvp 2 CoVec MVP 2 Jan 4, 2023
@rust-log-analyzer

This comment has been minimized.

@compiler-errors
Copy link
Member

Just a heads up that you can update your old PR with a force-push instead of opening up a new one, unless there's some other reason you closed the old PR 😅

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Jan 8, 2023

☔ The latest upstream changes (presumably #104658) made this pull request unmergeable. Please resolve the merge conflicts.

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Jan 14, 2023

☔ The latest upstream changes (presumably #106833) made this pull request unmergeable. Please resolve the merge conflicts.

@workingjubilee
Copy link
Member

Purely out of scholastic interest: what are "cooperative allocations", conceptually?

@rust-log-analyzer

This comment has been minimized.

@peter-lyons-kehl
Copy link
Contributor Author

Hi @workingjubilee. Thank you for improving Rust.

I admire your scholastic interest. I've added https://github.com/coop-rs/rust/wiki. Feel free to comment (raise an issue or start a discussion).

Any light on coop-rs#1, please? (It is about this pull request's failure: https://github.com/rust-lang/rust/actions/runs/3942485808/jobs/6746195481#step:26:786.) Or who could help?

…co_alloc_metadata_num_slots_with_preference(...)
@bors
Copy link
Contributor

bors commented Jan 21, 2023

☔ The latest upstream changes (presumably #107143) made this pull request unmergeable. Please resolve the merge conflicts.

@peter-lyons-kehl
Copy link
Contributor Author

Replaced with #107274.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants