Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression test for #100772 #106495

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Add regression test for #100772 #106495

merged 1 commit into from
Jan 10, 2023

Conversation

JohnTitor
Copy link
Member

Closes #100772
r? @compiler-errors
Signed-off-by: Yuki Okushi jtitor@2k36.org

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 5, 2023
@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 5, 2023

📌 Commit 974fea525318ab9398ad88f9e8b7b52528b31491 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 5, 2023
@rust-log-analyzer

This comment has been minimized.

@compiler-errors
Copy link
Member

@bors r-

r=me fixed

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 5, 2023
@JohnTitor
Copy link
Member Author

@bors r=compiler-errors

@bors
Copy link
Contributor

bors commented Jan 7, 2023

📌 Commit ce32867 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 7, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 7, 2023
…-errors

Add regression test for rust-lang#100772

Closes rust-lang#100772
r? `@compiler-errors`
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
@matthiaskrgr
Copy link
Member

@bors r-
rollup failure #106565 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 7, 2023
@JohnTitor
Copy link
Member Author

Applied the same flags as the tests on the codegen dir, hope it fixes the failure. Marking iffy as it may fail again.

@bors r=compiler-errors rollup=iffy

@JohnTitor
Copy link
Member Author

@bors r=compiler-errors

@bors
Copy link
Contributor

bors commented Jan 8, 2023

📌 Commit 156f4debbffb9059af7a54ce1b9ed28de0a667f7 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 8, 2023
@JohnTitor
Copy link
Member Author

@bors rollup=iffy

@bors
Copy link
Contributor

bors commented Jan 8, 2023

⌛ Testing commit 156f4debbffb9059af7a54ce1b9ed28de0a667f7 with merge 2b96cbceebd1d8c5cdac7926a856907c6650b5e1...

@bors
Copy link
Contributor

bors commented Jan 8, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 8, 2023
@rust-log-analyzer

This comment has been minimized.

@JohnTitor
Copy link
Member Author

Hmm, -Zsanitizer=cfi seems quite platform-specific (the codegen test passes because it's tested on limited targets, I guess?). It would weaken the test but using // only-x86_64-unknown-linux-gnu is a simple fix, @compiler-errors what do you think?

@compiler-errors
Copy link
Member

I think that's probably fine. I don't think it weakens the test much, given the nature of the original ICE. r=me with that fix applied.

Signed-off-by: Yuki Okushi <jtitor@2k36.org>
@JohnTitor
Copy link
Member Author

@bors r=compiler-errors

@bors
Copy link
Contributor

bors commented Jan 9, 2023

📌 Commit 1ab06ed has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 9, 2023
@bors
Copy link
Contributor

bors commented Jan 9, 2023

⌛ Testing commit 1ab06ed with merge 556e62fa3f9826d367915ff711700e278204556c...

@bors
Copy link
Contributor

bors commented Jan 9, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 9, 2023
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
  CACHE_DOMAIN: ci-caches.rust-lang.org
  IMAGE: aarch64-gnu
##[endgroup]
{"ipv6":true,"fixed-cidr-v6":"fd9a:8454:6789:13f7::/64"}
Job for docker.service canceled.
##[error]Process completed with exit code 1.
##[error]The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.

@JohnTitor
Copy link
Member Author

Spurious? @bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 9, 2023
@bors
Copy link
Contributor

bors commented Jan 10, 2023

⌛ Testing commit 1ab06ed with merge d53924d...

@bors
Copy link
Contributor

bors commented Jan 10, 2023

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing d53924d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 10, 2023
@bors bors merged commit d53924d into rust-lang:master Jan 10, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 10, 2023
@JohnTitor JohnTitor deleted the issue-100772 branch January 10, 2023 03:27
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d53924d): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.2% [1.2%, 1.2%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.4% [-2.4%, -2.4%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.6% [-2.4%, 1.2%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE: -Zsanitizer=cfi with allocator_api; transform_ty: unexpected Param(T/#0)
7 participants