-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not filter substs in remap_generic_params_to_declaration_params
.
#106503
Conversation
don't have the context to quickly review this. r? oli-obk with the hope that it's easier to review for them |
Ah wonderful... I was hoping we could nuke this hack. Your variance PR would resolve this issue correctly, so 👍 @bors r+ |
Do not filter substs in `remap_generic_params_to_declaration_params`. The relevant filtering should have been performed by borrowck. Fixes rust-lang#105826 r? types
The relevant filtering should have been performed by borrowck.
ebd22bf
to
b7bb8a5
Compare
@bors r=oli-obk p=1 |
⌛ Testing commit b7bb8a5 with merge 7bdc564531393b89f559ff9ac2db865aa30370de... |
💔 Test failed - checks-actions |
Spurious rustdoc failure @bors retry |
The job Click to see the possible cause of the failure (guessed by this bot)
|
☀️ Test successful - checks-actions |
Finished benchmarking commit (6d46b1e): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
…mulacrum [beta] backport rollup * Revert "Make nested RPITIT inherit the parent opaque's generics." rust-lang#106759 * Fix mpsc::SyncSender spinning behavior rust-lang#106701 * rustdoc: fix outdated lint section of the book rust-lang#106605 * Do not filter substs in remap_generic_params_to_declaration_params. rust-lang#106503 * Correct detection of elided lifetimes in impl-trait. rust-lang#106501 * Bump rust-installer rust-lang#106196 * Don't panic on stable since miri is not available there rust-lang#105901
The relevant filtering should have been performed by borrowck.
Fixes #105826
r? types