-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Insert whitespace to avoid ident concatenation in suggestion #106540
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @wesleywiser (rustbot has picked a reviewer for you, use r? to override) |
For reference, here's the current broken suggestion: error: incorrect braces around trait bounds
--> src/lib.rs:1:25
|
1 | fn foo2_no_space(_: &dyn(Drop + AsRef<str>)) {}
| ^ ^
|
help: remove the parentheses
|
1 - fn foo2_no_space(_: &dyn(Drop + AsRef<str>)) {}
1 + fn foo2_no_space(_: &dynDrop + AsRef<str>) {}
| |
Thanks for the PR @lowr. Could you please rebase atop current master? I'll approve it. |
0bbe3a4
to
807ebac
Compare
@cjgillot Done! |
@bors r+ rollup |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 29, 2023
…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#96763 (Fix maintainer validation message) - rust-lang#106540 (Insert whitespace to avoid ident concatenation in suggestion) - rust-lang#106763 (print why a test was ignored if its the only test specified) - rust-lang#106769 (libtest: Print why a test was ignored if it's the only test specified.) - rust-lang#106798 (Implement `signum` with `Ord`) - rust-lang#107006 (Output tree representation on thir-tree) - rust-lang#107078 (Update wording of invalid_doc_attributes docs.) - rust-lang#107169 (Pass `--locked` to the x test tidy call) - rust-lang#107431 (docs: remove colon from time header) - rust-lang#107432 (rustdoc: remove unused class `has-srclink`) - rust-lang#107448 (When stamp doesn't exist, should say Error, and print path to stamp file) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tweaks the suggestion of removing misplaced parentheses around trait bounds so as to avoid concatenating two identifiers. Although subtle, this should make outputs less surprising especially when applying the
MachineApplicable
suggestions automatically.