Rollup of 10 pull requests #106573

matthiaskrgr · 2023-01-07T19:43:24Z

Successful merges:

Migrating rustc_infer to session diagnostics (part 3) #101936 (Migrating rustc_infer to session diagnostics (part 3))
PhantomData layout guarantees #104081 (PhantomData layout guarantees)
Migrate codegen_ssa to diagnostics structs - [Part 3] #104543 (Migrate codegen_ssa to diagnostics structs - [Part 3])
Add O(1) Vec -> VecDeque conversion guarantee #105128 (Add O(1) Vec -> VecDeque conversion guarantee)
Fix process-panic-after-fork.rs to pass on newer versions of Android. #105517 (Fix process-panic-after-fork.rs to pass on newer versions of Android.)
Point out span where we could introduce higher-ranked lifetime #105859 (Point out span where we could introduce higher-ranked lifetime)
Detect closures assigned to binding in block #106509 (Detect closures assigned to binding in block)
docs: make HashSet::retain doctest more clear #106553 (docs: make HashSet::retain doctest more clear)
rustdoc: remove no-op mobile CSS .content { margin-left: 0 } #106556 (rustdoc: remove no-op mobile CSS .content { margin-left: 0 })
Change to immutable borrow when cloning element of RepeatN #106564 (Change to immutable borrow when cloning element of RepeatN)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

The test process-panic-after-fork.rs was checking that abort() resulted in SIGSEGV on Android. This non-standard behavior was fixed back in 2013, so let's fix the test to also accept the standard behavior on Android.

WIP - replacing span_invalid_monomorphization_error function. Still in progress due to its use in codegen_llvm inside macros

UPDATE - migrate constant span_bug to translatable diagnostic.

…cs macros

Fix rust-lang#58497.

matthiaskrgr · 2023-01-07T19:43:38Z

@bors r+ rollup=never p=10

bors · 2023-01-07T19:43:40Z

📌 Commit 3076f26 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2023-01-07T22:42:43Z

⌛ Testing commit 3076f26 with merge e5d46a5...

bors · 2023-01-08T01:33:58Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing e5d46a5 to master...

rust-timer · 2023-01-08T01:36:47Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#106564	54f23505deafc11b2ed853de4fa4eff6f2b7f098
#106556	8070c969ea418d6b1e974487acb99c701f733075
#106553	14d7c9d83845f8f0dac5afee3aff1f6b1d277d23
#106509	5c1406060a7df8015cf1a6b0bd006e19ce2090ff
#105859	8a11f19e98fc4abcbb9b754eafca1cec0ad606d0
#105517	af172fa08bfb523aeb6ff23fb8bddd235a57d8d4
#105128	27d85eefb1203db578049bdc6768ac8b2cef617b
#104543	a6e41579df479fc55ec1cddab0bd3202f5eb7b8a
#104081	d3ce24e3631f08b79d5dbfe610000365251cf684
#101936	f138838c2a5362ba79be51df5ff18845d94c2c4d

previous master: ee0412d1ef

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2023-01-08T02:53:26Z

Finished benchmarking commit (e5d46a5): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.2%, 0.3%]	4
Regressions ❌ (secondary)	0.5%	[0.3%, 1.0%]	22
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.3%	[0.2%, 0.3%]	4

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.7%	[-2.7%, -2.7%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.7%	[-2.7%, -2.7%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

rylev · 2023-01-09T10:46:54Z

Nothing really jumps out here as the most likely possibility of a regression. I think the following are possible (in rough order of likelihood):

I'll go through them and see if we can find the culprit.

@rust-timer build a6e41579df479fc55ec1cddab0bd3202f5eb7b8a

rust-timer · 2023-01-09T12:23:16Z

Finished benchmarking commit (a6e41579df479fc55ec1cddab0bd3202f5eb7b8a): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

rylev · 2023-01-09T12:46:12Z

@rust-timer build f138838c2a5362ba79be51df5ff18845d94c2c4d

rust-timer · 2023-01-09T15:02:31Z

Finished benchmarking commit (f138838c2a5362ba79be51df5ff18845d94c2c4d): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.2%, 0.3%]	4
Regressions ❌ (secondary)	0.5%	[0.2%, 1.5%]	18
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.3%	[0.2%, 0.3%]	4

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

rylev · 2023-01-09T15:49:01Z

It looks like #101936 is the reason for the performance regression. cc @IntQuant @compiler-errors @davidtwco

Mark-Simulacrum · 2023-01-10T14:50:31Z

Marking this as triaged and tagging #101936 instead with perf-regression.

joshlf and others added 30 commits November 6, 2022 16:08

PhantomData layout guarantees

72a9029

Add O(1) Vec -> VecDeque conversion guarantee

ac583f1

Fix process-panic-after-fork.rs to pass on newer versions of Android.

9553a4d

The test process-panic-after-fork.rs was checking that abort() resulted in SIGSEGV on Android. This non-standard behavior was fixed back in 2013, so let's fix the test to also accept the standard behavior on Android.

higher-ranked lifetime message

5cccb36

UPDATE - migrate base.rs to new diagnostics infrastructure

82cf6f2

ADD - fixme in type_names.rs until we are able to translate InterpError

78796ba

UPDATE - migrate constant.rs to new diagnostics infrastructure

d41112a

[WIP] UPDATE - migrate intrinsic.rs to new diagnostic infrastructure

e26366a

WIP - replacing span_invalid_monomorphization_error function. Still in progress due to its use in codegen_llvm inside macros

UPDATE - migrate fn simd_simple_float_intrinsic error messages

d1030fa

ADD - create and emit Bug support for Diagnostics

2774446

UPDATE - migrate constant span_bug to translatable diagnostic.

DELETE - fn span_invalid_monomorphization_error and localize intrinsi…

29d8c87

…cs macros

UPDATE - migrate outstanding diagnostic in link.rs

4d63d7d

Migrate named_anon_conflict.rs

8360a40

Migrate placeholder_error.rs

2118ff4

Migrate trait_impl_difference.rs

3935a81

Partial work on static_impl_trait.rs

0634b01

Rebase and fix

57fdd19

More descriptive names for ActualImplExplNotes variants

6c19c08

Split into several messages

71d24da

Use eager translation

eb7ce17

Rename subdiagnostic fields that do not need to be unique now

40b2218

Address changes of pr 103345

19b8579

Split infer_explicit_lifetime_required into several diags

7ecd064

Made ty_or_sig and trait_path use their actual types instead of String

62f9962

Fix nits

a861737

Fix broken rebase

dda3eba

Fix formatting

2a8b17d

eager is the default now

0c50e1f

Detect closures assigned to binding in block

ce6b717

Fix rust-lang#58497.

docs: make HashSet::retain doctest more clear

43bec83

rustbot added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jan 7, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 7, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 8, 2023

bors merged commit e5d46a5 into rust-lang:master Jan 8, 2023

rustbot added this to the 1.68.0 milestone Jan 8, 2023

rustbot added the perf-regression Performance regression. label Jan 8, 2023

This comment has been minimized.

Sign in to view

rustbot removed the perf-regression Performance regression. label Jan 9, 2023

This comment has been minimized.

Sign in to view

rustbot added the perf-regression Performance regression. label Jan 9, 2023

Mark-Simulacrum added the perf-regression-triaged The performance regression has been triaged. label Jan 10, 2023

matthiaskrgr deleted the rollup-zkgfsta branch March 16, 2024 18:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 10 pull requests #106573

Rollup of 10 pull requests #106573

matthiaskrgr commented Jan 7, 2023

matthiaskrgr commented Jan 7, 2023

bors commented Jan 7, 2023

bors commented Jan 7, 2023

bors commented Jan 8, 2023

rust-timer commented Jan 8, 2023

rust-timer commented Jan 8, 2023

rylev commented Jan 9, 2023

This comment has been minimized.

rust-timer commented Jan 9, 2023

rylev commented Jan 9, 2023

This comment has been minimized.

rust-timer commented Jan 9, 2023

rylev commented Jan 9, 2023

Mark-Simulacrum commented Jan 10, 2023

Rollup of 10 pull requests #106573

Rollup of 10 pull requests #106573

Conversation

matthiaskrgr commented Jan 7, 2023

matthiaskrgr commented Jan 7, 2023

bors commented Jan 7, 2023

bors commented Jan 7, 2023

bors commented Jan 8, 2023

rust-timer commented Jan 8, 2023

rust-timer commented Jan 8, 2023

Overall result: ❌ regressions - ACTION NEEDED

rylev commented Jan 9, 2023

This comment has been minimized.

rust-timer commented Jan 9, 2023

Overall result: no relevant changes - no action needed

rylev commented Jan 9, 2023

This comment has been minimized.

rust-timer commented Jan 9, 2023

Overall result: ❌ regressions - ACTION NEEDED

rylev commented Jan 9, 2023

Mark-Simulacrum commented Jan 10, 2023