Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not emit wrong E0308 suggestion for closure mismatch #106581

Merged
merged 2 commits into from
Jan 8, 2023

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Jan 8, 2023

Found in #76353.

@rustbot
Copy link
Collaborator

rustbot commented Jan 8, 2023

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 8, 2023
@estebank
Copy link
Contributor Author

estebank commented Jan 8, 2023

r? @compiler-errors

@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 8, 2023

📌 Commit ebbc5da has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 8, 2023
JohnTitor pushed a commit to JohnTitor/rust that referenced this pull request Jan 8, 2023
…r-errors

Do not emit wrong E0308 suggestion for closure mismatch

Found in rust-lang#76353.
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 8, 2023
Rollup of 8 pull requests

Successful merges:

 - rust-lang#103104 (Stabilize `main_separator_str`)
 - rust-lang#106410 (Suggest `mut self: &mut Self` for `?Sized` impls)
 - rust-lang#106457 (Adjust comments about pre-push.sh hook)
 - rust-lang#106546 (jsondoclint: Check local items in `paths` are also in `index`.)
 - rust-lang#106557 (Add some UI tests and reword error-code docs)
 - rust-lang#106562 (Clarify examples for `VecDeque::get/get_mut`)
 - rust-lang#106580 (remove unreachable error code `E0313`)
 - rust-lang#106581 (Do not emit wrong E0308 suggestion for closure mismatch)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 789ebdc into rust-lang:master Jan 8, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants