Skip to content

Render missing generics suggestion verbosely #106608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 13, 2023
Merged

Render missing generics suggestion verbosely #106608

merged 2 commits into from
Jan 13, 2023

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented Jan 8, 2023 •
edited
Loading

It's a bit easier to read like this, especially ones that are appending new generics onto an existing list, like ": , T" which render somewhat poorly inline.

Also don't suggest dyn as a type parameter to add, even if technically that's valid in edition 2015.

@rustbot
Copy link
Collaborator

rustbot commented Jan 8, 2023

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 8, 2023
@compiler-errors
Copy link
Member Author

r? @estebank

@rustbot rustbot assigned estebank and unassigned oli-obk Jan 8, 2023
@estebank
Copy link
Contributor

estebank commented Jan 9, 2023

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 9, 2023

📌 Commit 21ff605 has been approved by estebank

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 9, 2023
JohnTitor pushed a commit to JohnTitor/rust that referenced this pull request Jan 9, 2023
Rollup merge of rust-lang#106608 - compiler-errors:missing-generics-v…
36904ec 
…erbose, r=estebank

Render missing generics suggestion verbosely

It's a bit easier to read like this, especially ones that are appending new generics onto an existing list, like ": `, T`" which render somewhat poorly inline.

Also don't suggest `dyn` as a type parameter to add, even if technically that's valid in edition 2015.
@JohnTitor JohnTitor mentioned this pull request Jan 9, 2023
Closed
JohnTitor pushed a commit to JohnTitor/rust that referenced this pull request Jan 9, 2023
Rollup merge of rust-lang#106608 - compiler-errors:missing-generics-v…
e9b0aed 
…erbose, r=estebank

Render missing generics suggestion verbosely

It's a bit easier to read like this, especially ones that are appending new generics onto an existing list, like ": `, T`" which render somewhat poorly inline.

Also don't suggest `dyn` as a type parameter to add, even if technically that's valid in edition 2015.
@JohnTitor JohnTitor mentioned this pull request Jan 9, 2023
Closed
@fee1-dead
Copy link
Member

@bors r-

Failed here

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 9, 2023
@compiler-errors compiler-errors force-pushed the missing-generics-verbose branch from 21ff605 to 7c2dff0 Compare January 9, 2023 17:47
@rustbot
Copy link
Collaborator

rustbot commented Jan 9, 2023

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@compiler-errors
Copy link
Member Author

Blessed clippy test failure

@bors r=estebank

@bors
Copy link
Collaborator

bors commented Jan 9, 2023

📌 Commit 7c2dff0 has been approved by estebank

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 9, 2023
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Jan 9, 2023
@compiler-errors
Rollup merge of rust-lang#106608 - compiler-errors:missing-generics-v…
32aeb3f 
…erbose, r=estebank

Render missing generics suggestion verbosely

It's a bit easier to read like this, especially ones that are appending new generics onto an existing list, like ": `, T`" which render somewhat poorly inline.

Also don't suggest `dyn` as a type parameter to add, even if technically that's valid in edition 2015.
@compiler-errors compiler-errors mentioned this pull request Jan 9, 2023
Closed
@compiler-errors
Copy link
Member Author

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 9, 2023
@compiler-errors compiler-errors force-pushed the missing-generics-verbose branch from 7c2dff0 to bf0623e Compare January 12, 2023 22:04
@compiler-errors
Copy link
Member Author

@bors r=estebank

@bors
Copy link
Collaborator

bors commented Jan 12, 2023

📌 Commit bf0623e has been approved by estebank

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 12, 2023
@JohnTitor JohnTitor mentioned this pull request Jan 13, 2023
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 13, 2023
@matthiaskrgr
Rollup merge of rust-lang#106608 - compiler-errors:missing-generics-v…
a102fb1 
…erbose, r=estebank

Render missing generics suggestion verbosely

It's a bit easier to read like this, especially ones that are appending new generics onto an existing list, like ": `, T`" which render somewhat poorly inline.

Also don't suggest `dyn` as a type parameter to add, even if technically that's valid in edition 2015.
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 13, 2023
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 13, 2023
@bors
Auto merge of rust-lang#106801 - JohnTitor:rollup-xqkraw0, r=JohnTitor
5ca6f7d 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#106608 (Render missing generics suggestion verbosely)
 - rust-lang#106716 ([RFC 2397] Deny incorrect locations)
 - rust-lang#106754 (Rename `Ty::is_ty_infer` -> `Ty::is_ty_or_numeric_infer`)
 - rust-lang#106782 (Ignore tests move in git blame)
 - rust-lang#106785 (Make blame spans better for impl wfcheck)
 - rust-lang#106791 (Fix ICE formatting)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9a2f393 into rust-lang:master Jan 13, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 13, 2023
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jan 27, 2023
Rollup merge of rust-lang#106608 - compiler-errors:missing-generics-v…
71b99c4 
…erbose, r=estebank

Render missing generics suggestion verbosely

It's a bit easier to read like this, especially ones that are appending new generics onto an existing list, like ": `, T`" which render somewhat poorly inline.

Also don't suggest `dyn` as a type parameter to add, even if technically that's valid in edition 2015.
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jan 27, 2023
@bors
Auto merge of rust-lang#106801 - JohnTitor:rollup-xqkraw0, r=JohnTitor
ac95db6 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#106608 (Render missing generics suggestion verbosely)
 - rust-lang#106716 ([RFC 2397] Deny incorrect locations)
 - rust-lang#106754 (Rename `Ty::is_ty_infer` -> `Ty::is_ty_or_numeric_infer`)
 - rust-lang#106782 (Ignore tests move in git blame)
 - rust-lang#106785 (Make blame spans better for impl wfcheck)
 - rust-lang#106791 (Fix ICE formatting)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@compiler-errors compiler-errors deleted the missing-generics-verbose branch August 11, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
6 participants
@compiler-errors @rustbot @estebank @bors @fee1-dead @oli-obk