-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix aarch64-unknown-linux-gnu_ilp32 target #106646
Conversation
This was broken because the synthetic object files produced by rustc were for 64-bit AArch64, which caused link failures when combined with 32-bit ILP32 object files. This PR updates the object crate to 0.30.1 which adds support for generating ILP32 AArch64 object files.
(rustbot has picked a reviewer for you, use r? to override) |
cc @bjorn3 -- The cranelift backend still uses object v0.29 since it seems to be tied to cranelift's use of the object crate. |
That should be fine, right? cg_clif doesn't mix the object version used by rustc with the one compiled when building cg_clif. It also doesn't have an effect on this target being supported or not as Cranelift doesn't support 32bit pointers on AArch64 anyway. |
Yes it should be fine, it was just FYI. |
@bors r+ rollup=iffy |
☀️ Test successful - checks-actions |
Finished benchmarking commit (44a500c): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
This was broken because the synthetic object files produced by rustc were for 64-bit AArch64, which caused link failures when combined with 32-bit ILP32 object files.
This PR updates the object crate to 0.30.1 which adds support for generating ILP32 AArch64 object files.