Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove a couple of #[doc(hidden)] pub fn and their #[feature] gates #106677

Merged
merged 1 commit into from
Feb 12, 2023
Merged

Remove a couple of #[doc(hidden)] pub fn and their #[feature] gates #106677

merged 1 commit into from
Feb 12, 2023

Conversation

tbu-
Copy link
Contributor

@tbu- tbu- commented Jan 10, 2023

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Jan 10, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @scottmcm (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 10, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jan 10, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@tbu- tbu- force-pushed the pr_less_doc_hidden_pub branch 2 times, most recently from 22c1816 to f6a64e9 Compare January 10, 2023 14:59
@bors
Copy link
Contributor

bors commented Feb 9, 2023

☔ The latest upstream changes (presumably #107828) made this pull request unmergeable. Please resolve the merge conflicts.

@tbu- tbu- force-pushed the pr_less_doc_hidden_pub branch from f6a64e9 to 77c85e9 Compare February 11, 2023 15:04
scottmcm
scottmcm reviewed Feb 11, 2023
View reviewed changes
library/core/src/char/convert.rs
match self.kind {
CharErrorKind::EmptyString => "cannot parse char from empty string",
CharErrorKind::TooManyChars => "too many characters in string",
}
}
}

#[derive(Copy, Clone, Debug, PartialEq, Eq)]
enum CharErrorKind {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: in future, please try to keep things in a relative order such that things like this type don't show as delete-then-add in the diff.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. Not sure why I did this.

@scottmcm
Copy link
Member

Thanks! Cleaning these up to just be the Error trait method directly makes sense to me.

@bors r+ rollup=iffy (should be fine, but cfg(no_fp_fmt_parse) stuff always scares me a bit since the PR checks don't build that)

@bors
Copy link
Contributor

bors commented Feb 11, 2023

📌 Commit 77c85e9 has been approved by scottmcm

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 11, 2023
@bors
Copy link
Contributor

bors commented Feb 11, 2023

⌛ Testing commit 77c85e9 with merge d094016...

@bors
Copy link
Contributor

bors commented Feb 12, 2023

☀️ Test successful - checks-actions
Approved by: scottmcm
Pushing d094016 to master...

1 similar comment
@bors
Copy link
Contributor

bors commented Feb 12, 2023

☀️ Test successful - checks-actions
Approved by: scottmcm
Pushing d094016 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 12, 2023
@bors bors merged commit d094016 into rust-lang:master Feb 12, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 12, 2023
@bors bors mentioned this pull request Feb 12, 2023
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d094016): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.4% [1.4%, 1.4%] 1
Regressions ❌
(secondary)		 2.9% [2.2%, 3.7%] 4
Improvements ✅
(primary)		 -2.4% [-3.7%, -1.2%] 2
Improvements ✅
(secondary)		 -1.7% [-1.7%, -1.7%] 1
All ❌✅ (primary) -1.2% [-3.7%, 1.4%] 3

Cycles

This benchmark run did not return any relevant results for this metric.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottmcm scottmcm scottmcm left review comments

Assignees

@scottmcm scottmcm

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.69.0
Development

Successfully merging this pull request may close these issues.
5 participants
@tbu- @rustbot @bors @scottmcm @rust-timer