Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] Clippy: Move manual_clamp to nursery #106731

Merged
merged 1 commit into from
Jan 14, 2023

Conversation

flip1995
Copy link
Member

There was a lot of discussion about this lint in rust-lang/rust-clippy#9484 (comment)

We decided to move the lint to nursery. But since this lint broke code of many popular projects, we don't want to wait another release cycle until this move gets into stable. So we'd like to backport this commit to beta.

cc @rust-lang/clippy for approval from the Clippy side.

@rustbot
Copy link
Collaborator

rustbot commented Jan 11, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot
Copy link
Collaborator

rustbot commented Jan 11, 2023

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 11, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jan 11, 2023

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@flip1995 flip1995 changed the title Move manual_clamp to nursery [beta] Clippy: Move manual_clamp to nursery Jan 11, 2023
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented Jan 14, 2023

📌 Commit e74700c has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 14, 2023
@bors
Copy link
Contributor

bors commented Jan 14, 2023

⌛ Testing commit e74700c with merge 7a9ae0c...

@bors
Copy link
Contributor

bors commented Jan 14, 2023

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 7a9ae0c to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 14, 2023
@bors bors merged commit 7a9ae0c into rust-lang:beta Jan 14, 2023
@rustbot rustbot added this to the 1.67.0 milestone Jan 14, 2023
@flip1995 flip1995 deleted the clippy_backport branch January 14, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants