Forbid keywords as lifetime parameters names. #10675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| && !token::is_keyword(token::keywords::Static, tok) | ||
| && !token::is_keyword(token::keywords::Self, tok) { | ||
| fatal_span(rdr, start, rdr.last_pos, | ||
| ~"Invalid lifetime name"); |
There was a problem hiding this comment.
nit: error messages start with a lowercase letter
|
@LeoTestard: |
|
Needs rebase. |
|
@brson : done :) |
bors
added a commit
that referenced
this pull request
Dec 6, 2013
Fixes #10565. `'self` is still allowed for the moment, as it is used everywhere in the codebase. And I'm not sure if it still has a special meaning currently or not.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 23, 2023
[arithmetic_side_effects] Cache symbols An internal-only modification to speed up the processing of symbols because "intern" isn't very cheap, even more when you are doing the same thing for every method expression. changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10565.
'selfis still allowed for the moment, as it is used everywhere in the codebase. And I'm not sure if it still has a special meaning currently or not.