Tweak "borrow closure argument" suggestion #106891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
tests/ui/mismatched_types/closure-arg-type-mismatch-issue-45727.rs
Outdated
Show resolved
Hide resolved
compiler/rustc_trait_selection/src/traits/error_reporting/suggestions.rs
Outdated
Show resolved
Hide resolved
petrochenkov
added
S-waiting-on-author
estebank
commented
Jan 19, 2023
Comment on lines
+21
to
+24
| help: do not borrow the argument | ||
| | | ||
| LL | foo(move |char| v); | ||
| | ~~~~ |
There was a problem hiding this comment.
I'm not adding this incorrect suggestion, just changing its presentation, but we need to fix this in a follow up.
estebank
added
S-waiting-on-review
|
r=me after squashing commits. |
rustbot
added
S-waiting-on-author
|
@bors r=petrochenkov |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 20, 2023
Tweak "borrow closure argument" suggestion Fix rust-lang#45727.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 20, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#106699 ([drop tracking] Visit break expressions ) - rust-lang#106738 (Fix known-bug annotations) - rust-lang#106891 (Tweak "borrow closure argument" suggestion) - rust-lang#106928 (add raw identifier for keyword in suggestion) - rust-lang#107065 (Clippy: Make sure to include in beta: Move `unchecked_duration_subtraction` to pedantic) - rust-lang#107068 (autoderive Subdiagnostic for AddtoExternBlockSuggestion) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #45727.