Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to EarlyBinder for item_bounds query #106970

Merged
merged 3 commits into from
Jan 18, 2023
Merged

Switch to EarlyBinder for item_bounds query #106970

merged 3 commits into from
Jan 18, 2023

Conversation

kylematsuda
Copy link
Contributor

@kylematsuda kylematsuda commented Jan 17, 2023 •
edited
Loading

Part of the work to finish #105779 (also see rust-lang/types-team#78).

Several queries X have a bound_X variant that wraps the output in EarlyBinder. This adds EarlyBinder to the return type of the item_bounds query and removes bound_item_bounds.

r? @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 17, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jan 17, 2023

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

lcnr
lcnr reviewed Jan 17, 2023
View reviewed changes
Copy link
Contributor

@lcnr lcnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after fixing a bug in clippy 😁

@lcnr
Copy link
Contributor

lcnr commented Jan 17, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 17, 2023

📌 Commit f193eff has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 17, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 17, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 17, 2023
@bors
Auto merge of rust-lang#106998 - matthiaskrgr:rollup-hmfisji, r=matth…
edefa41 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#104505 (Remove double spaces after dots in comments)
 - rust-lang#106784 (prevent E0512 from emitting [type error] by checking the references_error)
 - rust-lang#106834 (new trait solver: only consider goal changed if response is not identity)
 - rust-lang#106889 (Mention the lack of `windows_mut` in `windows`)
 - rust-lang#106963 (Use `scope_expr_id` from `ProbeCtxt`)
 - rust-lang#106970 (Switch to `EarlyBinder` for `item_bounds` query)
 - rust-lang#106980 (Hide `_use_mk_alias_ty_instead` in `<AliasTy as Debug>::fmt`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3d7677d into rust-lang:master Jan 18, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcnr lcnr lcnr left review comments

Assignees

@lcnr lcnr

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
4 participants
@kylematsuda @rustbot @lcnr @bors