Add and use expect methods to hir. #107125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
compiler/rustc_hir/src/hir.rs
Outdated
| /// Expect an [`ItemKind::ExternCrate`] or panic. | ||
| #[track_caller] | ||
| pub fn expect_extern_crate(&self) -> Option<Symbol> { | ||
| let ItemKind::ExternCrate(s) = self.kind else { unreachable!() }; |
There was a problem hiding this comment.
these should probably be bug!s
There was a problem hiding this comment.
even more ideally, they'd say "expected an extern crate, got {:?}" or something -- makes it much easier at a glance (or a stack trace submitted on an issue) to know what's up
There was a problem hiding this comment.
I don't think bug!s are available at this point in the crate graph :(
There was a problem hiding this comment.
nooooooo
ok well can u at least improve the panic message?
There was a problem hiding this comment.
Yes, I'll improve the messages (not today tho, I'm tired and tired)
This comment has been minimized.
This comment has been minimized.
Noratrieb
added
S-waiting-on-author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
Noratrieb
reviewed
Jan 30, 2023
| #[track_caller] | ||
| fn expect_failed(&self, expected: &'static str) -> ! { | ||
| panic!("expected {expected} node, found {self:?}") | ||
| } |
There was a problem hiding this comment.
This file is way too big and should be split apart into like defs, helpers, expects etc. at some point :(
But it's fine for this PR
There was a problem hiding this comment.
yeah, a lot of files are like this :(
Noratrieb
reviewed
Jan 30, 2023
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 30, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#107125 (Add and use expect methods to hir.) - rust-lang#107172 (Reimplement NormalizeArrayLen based on SsaLocals) - rust-lang#107177 (Keep all theme-updating logic together) - rust-lang#107424 (Make Vec::clone_from and slice::clone_into share the same code) - rust-lang#107455 (use a more descriptive name) - rust-lang#107465 (`has_allow_dead_code_or_lang_attr` micro refactor) - rust-lang#107469 (Change turbofish context link to an archive link) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
WaffleLapkin
deleted the
expect_an_item_in_your_hir_by_the_next_morning
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The future has come.
r? @Nilstrieb
tbh I'm not even sure if it's worth it