Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently use dominates instead of is_dominated_by #107153

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Jan 21, 2023

There is a number of APIs that answer dominance queries. Previously they were named either "dominates" or "is_dominated_by". Consistently use the "dominates" form.

No functional changes.

There is a number of APIs that answer dominance queries. Previously they
were named either "dominates" or "is_dominated_by". Consistently use the
"dominates" form.

No functional changes.
@rustbot
Copy link
Collaborator

rustbot commented Jan 21, 2023

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 21, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jan 21, 2023

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@oli-obk
Copy link
Contributor

oli-obk commented Jan 23, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 23, 2023

📌 Commit 955e7fb has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 23, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 23, 2023
Rollup of 7 pull requests

Successful merges:

 - rust-lang#106796 (BPF: Disable atomic CAS)
 - rust-lang#106886 (Make stage2 rustdoc and proc-macro-srv disableable in x.py install)
 - rust-lang#107101 (Filter param-env predicates for errors before calling `to_opt_poly_trait_pred`)
 - rust-lang#107109 (ThinBox: Add intra-doc-links for Metadata)
 - rust-lang#107148 (remove error code from `E0789`, add UI test/docs)
 - rust-lang#107151 (Instantiate dominators algorithm only once)
 - rust-lang#107153 (Consistently use dominates instead of is_dominated_by)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit eae7f94 into rust-lang:master Jan 23, 2023
@rustbot rustbot added this to the 1.69.0 milestone Jan 23, 2023
@tmiasko tmiasko deleted the dominates branch January 23, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants