Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new_outside_solver -> evaluate_root_goal #107227

Merged
merged 1 commit into from
Jan 25, 2023
Merged

new_outside_solver -> evaluate_root_goal #107227

merged 1 commit into from
Jan 25, 2023
+32 −17

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Jan 23, 2023

r? @rust-lang/initiative-trait-system-refactor

@rustbot
Copy link
Collaborator

rustbot commented Jan 23, 2023

Team or group rust-lang/initiative-trait-system-refactor not found.

rust-lang team names can be found at https://github.com/rust-lang/team/tree/master/teams.
Reviewer group names can be found in triagebot.toml in this repo.

@rustbot
Copy link
Collaborator

rustbot commented Jan 23, 2023

r? @Nilstrieb

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Jan 23, 2023
@lcnr
Copy link
Contributor Author

lcnr commented Jan 23, 2023

r? @compiler-errors

@rustbot rustbot assigned compiler-errors and unassigned Noratrieb Jan 23, 2023
@lcnr lcnr force-pushed the solver-new-external-api branch from 7561e16 to 033047a Compare January 23, 2023 14:58
@compiler-errors
Copy link
Member

@bors r+ rollup (only affects new solver)

@bors
Copy link
Collaborator

bors commented Jan 23, 2023

📌 Commit 033047a has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 23, 2023
@compiler-errors
Copy link
Member

Uh I did not see this was a draft

@bors r-

r=me if it was not meant to be a draft 😂

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 23, 2023
@lcnr lcnr marked this pull request as ready for review January 23, 2023 16:01
@rustbot
Copy link
Collaborator

rustbot commented Jan 23, 2023

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

@lcnr
Copy link
Contributor Author

lcnr commented Jan 23, 2023

@bors r=compiler-errors rollup

@bors
Copy link
Collaborator

bors commented Jan 23, 2023

📌 Commit 033047a has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 23, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 23, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 23, 2023
@matthiaskrgr
Rollup merge of rust-lang#107227 - lcnr:solver-new-external-api, r=co…
7c055af 
…mpiler-errors

`new_outside_solver` ->  `evaluate_root_goal`

r? `@rust-lang/initiative-trait-system-refactor`
@Dylan-DPC Dylan-DPC mentioned this pull request Jan 24, 2023
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jan 24, 2023
@Dylan-DPC
Rollup merge of rust-lang#107227 - lcnr:solver-new-external-api, r=co…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
fd3bca1 
…mpiler-errors

`new_outside_solver` ->  `evaluate_root_goal`

r? ``@rust-lang/initiative-trait-system-refactor``
@Dylan-DPC Dylan-DPC mentioned this pull request Jan 25, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 25, 2023
@bors
Auto merge of rust-lang#107290 - Dylan-DPC:rollup-tovojhr, r=Dylan-DPC
95b61d1 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#105552 (Add help message about function pointers)
 - rust-lang#106583 (Suggest coercion of `Result` using `?`)
 - rust-lang#106767 (Allow setting CFG_DISABLE_UNSTABLE_FEATURES to 0)
 - rust-lang#106823 (Allow fmt::Arguments::as_str() to return more Some(_).)
 - rust-lang#107166 (rustc_metadata: Support non-`Option` nullable values in metadata tables)
 - rust-lang#107213 (Add suggestion to remove if in let..else block)
 - rust-lang#107223 (`sub_ptr()` is equivalent to `usize::try_from().unwrap_unchecked()`, not `usize::from().unwrap_unchecked()`)
 - rust-lang#107227 (`new_outside_solver` ->  `evaluate_root_goal`)
 - rust-lang#107232 (rustdoc: simplify settings popover DOM, CSS, JS)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 139a3c5 into rust-lang:master Jan 25, 2023
@rustbot rustbot added this to the 1.69.0 milestone Jan 25, 2023
@lcnr lcnr deleted the solver-new-external-api branch January 25, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Milestone
1.69.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lcnr @rustbot @compiler-errors @bors @Noratrieb