Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Begin migrating rustdoc diagnostics for translation #107246

Closed

Conversation

cassaundra
Copy link
Contributor

@cassaundra cassaundra commented Jan 24, 2023

Currently a draft while I translate the remaining errors, so not ready for review. When finished I will rebase and tidy up these work-in-progress commits.

This PR does not address the 23 diagnostics in passes/collect_intra_doc_links.rs and a bunch of other ones using the internal Error type (consisting of a path and string), but I plan to do those next.

r? @davidtwco

To-do

Error sites

Error sites to fix (indicative of but not necessarily corresponding to individual errors):

  • clean/types.rs (1/1)
  • config.rs (13/16)
  • core.rs (2/2)
  • externalfiles.rs (2/2)
  • html/markdown.rs (1/1)
  • html/render/mod.rs (1/1)
  • passes/check_doc_test_visibility.rs (2/2)
  • passes/lint/bare_urls.rs (1/1)
  • passes/lint/check_code_block_syntax.rs (0/1)
  • passes/lint/html_tags.rs (1/1)
  • scrape_examples.rs (0/1)
  • visit_ast.rs (1/1)
  • lib.rs (0/1)

Total: 25/31 (81%)

Other tasks

  • Re-order and rename errors.
  • Clean up and consolidate commits.
  • Qualify instead of import errors (see relevant Zulip discussion).

@rustbot rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jan 24, 2023
@cassaundra
Copy link
Contributor Author

@rustbot label -S-waiting-on-review +S-waiting-on-author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 24, 2023
@rust-log-analyzer

This comment has been minimized.

@cassaundra cassaundra changed the title Migrate rustdoc diagnostics for translation Begin migrating rustdoc diagnostics for translation Jan 25, 2023
@cassaundra cassaundra force-pushed the rustdoc-translation-migration branch from c80124f to 9100596 Compare January 25, 2023 20:54
|
5 | / /// foo
6 | | ///
7 | | /// ```compile-fail,compilefail,comPile_fail
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason only the first of the typos on this line cause an error to be emitted now. I'm not sure why this is, but I imagine it has something to do with the difference between struct_span_lint_hir and emit_spanned_lint. I'll look into it more later...

@@ -5,7 +5,7 @@ LL | INVALID_FUNC();
| ^^^^^^^^^^^^ could not resolve path `INVALID_FUNC`
|
= note: this error was originally ignored because you are running `rustdoc`
= note: try running again with `rustc` or `cargo check` and you may get a more detailed error
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made more sense for this to be a help instead of a note, but I can save these stylistic changes for later.

@cassaundra cassaundra force-pushed the rustdoc-translation-migration branch from 9100596 to 79fbd02 Compare January 25, 2023 21:02
@cassaundra cassaundra force-pushed the rustdoc-translation-migration branch from 79fbd02 to 0dcccb7 Compare January 25, 2023 21:16
@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Jan 27, 2023

☔ The latest upstream changes (presumably #107343) made this pull request unmergeable. Please resolve the merge conflicts.

@cassaundra cassaundra force-pushed the rustdoc-translation-migration branch from 7697396 to 9234f1f Compare January 28, 2023 00:51
@jyn514
Copy link
Member

jyn514 commented Apr 26, 2023

Hi @cassaundra, it's been a while. Do you know when you'll have a chance to come back to this PR? It's ok if you don't switch all the diagnostics at once, the work you've done so far is already very helpful :)

See https://rustc-dev-guide.rust-lang.org/git.html#advanced-rebasing for instructions on how to rebase and fix conflicts.

@Dylan-DPC
Copy link
Member

Closing this as inactive. Feel free to reöpen this pr or create a new pr if you get the time to work on this. Thanks

@Dylan-DPC Dylan-DPC closed this Oct 12, 2023
@Dylan-DPC Dylan-DPC added S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants