-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Begin migrating rustdoc diagnostics for translation #107246
Begin migrating rustdoc diagnostics for translation #107246
Conversation
@rustbot label -S-waiting-on-review +S-waiting-on-author |
This comment has been minimized.
This comment has been minimized.
c80124f
to
9100596
Compare
| | ||
5 | / /// foo | ||
6 | | /// | ||
7 | | /// ```compile-fail,compilefail,comPile_fail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason only the first of the typos on this line cause an error to be emitted now. I'm not sure why this is, but I imagine it has something to do with the difference between struct_span_lint_hir
and emit_spanned_lint
. I'll look into it more later...
@@ -5,7 +5,7 @@ LL | INVALID_FUNC(); | |||
| ^^^^^^^^^^^^ could not resolve path `INVALID_FUNC` | |||
| | |||
= note: this error was originally ignored because you are running `rustdoc` | |||
= note: try running again with `rustc` or `cargo check` and you may get a more detailed error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made more sense for this to be a help instead of a note, but I can save these stylistic changes for later.
9100596
to
79fbd02
Compare
79fbd02
to
0dcccb7
Compare
This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #107343) made this pull request unmergeable. Please resolve the merge conflicts. |
7697396
to
9234f1f
Compare
Hi @cassaundra, it's been a while. Do you know when you'll have a chance to come back to this PR? It's ok if you don't switch all the diagnostics at once, the work you've done so far is already very helpful :) See https://rustc-dev-guide.rust-lang.org/git.html#advanced-rebasing for instructions on how to rebase and fix conflicts. |
Closing this as inactive. Feel free to reöpen this pr or create a new pr if you get the time to work on this. Thanks |
Currently a draft while I translate the remaining errors, so not ready for review. When finished I will rebase and tidy up these work-in-progress commits.
This PR does not address the 23 diagnostics in
passes/collect_intra_doc_links.rs
and a bunch of other ones using the internalError
type (consisting of a path and string), but I plan to do those next.r? @davidtwco
To-do
Error sites
Error sites to fix (indicative of but not necessarily corresponding to individual errors):
clean/types.rs
(1/1)config.rs
(13/16)core.rs
(2/2)externalfiles.rs
(2/2)html/markdown.rs
(1/1)html/render/mod.rs
(1/1)passes/check_doc_test_visibility.rs
(2/2)passes/lint/bare_urls.rs
(1/1)passes/lint/check_code_block_syntax.rs
(0/1)passes/lint/html_tags.rs
(1/1)scrape_examples.rs
(0/1)visit_ast.rs
(1/1)lib.rs
(0/1)Total: 25/31 (81%)
Other tasks