Remove the @ boxes from extra::json
#10727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is awesome! Last time I tried doing this lifetimes got the best of me and the compiler gave me lots of ICEs, but I'm glad to see that it's all working now. I think that @pcwalton is actually trying to change |
|
@alexcrichton: Sure. I updated the PR with |
| let s = @mut MemWriter::new(); | ||
| self.to_pretty_writer(s as @mut io::Writer); | ||
| let mut s = MemWriter::new(); | ||
| self.to_pretty_writer(&mut s as &mut io::Writer); | ||
| str::from_utf8(s.inner_ref().as_slice()) |
There was a problem hiding this comment.
Could you convert this to str::from_utf8_owned(s.inner()) to save a copy? (Similarly for all the other places (librustdoc, etc.) that use (@mut MemWriter).inner_ref(); including the ToStr for Json instance in this file, which you appear to have not removed @mut from?)
bors
added a commit
that referenced
this pull request
Nov 30, 2013
This PR does some small modernizations to the json library. First is to remove the `@` boxes, second is to rename the constructors to `new`.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
May 20, 2023
…shearth
Extend `trait_duplication_in_bounds` to cover trait objects
This PR extends `trait_duplication_in_bounds` to cover trait objects.
Currently,
```rs
fn foo(_a: &(dyn Any + Send + Send)) {}
```
generates no warnings. With this PR, it will complain about a duplicate trait and can remove it
Moved from rust-lang#110991
changelog: [`trait_duplication_in_bounds`]: warn on duplicate trait object constraints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does some small modernizations to the json library. First is to remove the
@boxes, second is to rename the constructors tonew.