Disable ConstGoto opt in cleanup blocks #107323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
|
Thanks! r=me when CI passes. @bors delegate=JakobDegen |
|
✌️ @JakobDegen can now approve this pull request |
|
@bors r=tmiasko |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 26, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#106904 (Preserve split DWARF files when building archives.) - rust-lang#106971 (Handle diagnostics customization on the fluent side (for one specific diagnostic)) - rust-lang#106978 (Migrate mir_build's borrow conflicts) - rust-lang#107150 (`ty::tls` cleanups) - rust-lang#107168 (Use a type-alias-impl-trait in `ObligationForest`) - rust-lang#107189 (Encode info for Adt in a single place.) - rust-lang#107322 (Custom mir: Add support for some remaining, easy to support constructs) - rust-lang#107323 (Disable ConstGoto opt in cleanup blocks) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #107315 .
There is probably a smaller hammer that we could use here, but none that is super obviously correct. We can always revisit this in the future.
Could not add a test because custom mir does not support cleanup blocks. However, did check that the fallible_iterator crate no longer ICEs with the other PR cherry picked.
r? @tmiasko