-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Also erase substs for new infcx in pin move error #107422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
tests/ui/moves/pin-mut-reborrow-infer-var-issue-107419.fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
// run-rustfix | ||
use std::pin::Pin; | ||
|
||
fn foo(_: &mut ()) {} | ||
|
||
fn main() { | ||
let mut uwu = (); | ||
let mut r = Pin::new(&mut uwu); | ||
foo(r.as_mut().get_mut()); | ||
foo(r.get_mut()); //~ ERROR use of moved value | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
// run-rustfix | ||
use std::pin::Pin; | ||
|
||
fn foo(_: &mut ()) {} | ||
|
||
fn main() { | ||
let mut uwu = (); | ||
let mut r = Pin::new(&mut uwu); | ||
foo(r.get_mut()); | ||
foo(r.get_mut()); //~ ERROR use of moved value | ||
} |
20 changes: 20 additions & 0 deletions
20
tests/ui/moves/pin-mut-reborrow-infer-var-issue-107419.stderr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
error[E0382]: use of moved value: `r` | ||
--> $DIR/pin-mut-reborrow-infer-var-issue-107419.rs:10:9 | ||
| | ||
LL | let mut r = Pin::new(&mut uwu); | ||
| ----- move occurs because `r` has type `Pin<&mut ()>`, which does not implement the `Copy` trait | ||
LL | foo(r.get_mut()); | ||
| --------- `r` moved due to this method call | ||
LL | foo(r.get_mut()); | ||
| ^ value used here after move | ||
| | ||
note: `Pin::<&'a mut T>::get_mut` takes ownership of the receiver `self`, which moves `r` | ||
--> $SRC_DIR/core/src/pin.rs:LL:COL | ||
help: consider reborrowing the `Pin` instead of moving it | ||
| | ||
LL | foo(r.as_mut().get_mut()); | ||
| +++++++++ | ||
|
||
error: aborting due to previous error | ||
|
||
For more information about this error, try `rustc --explain E0382`. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we even create a new infcx here instead of using
self.infcx
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regions already solve so can_eq ices
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@compiler-errors suggested it in #106095 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remember that someone told me the reason behind this before and I forgot 😅
might be nice to add a comment about this here, but apart from that this does feel like a pretty good solution 🤔