-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove unused static data for to_lowercase #107502
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
remove a ton of unused empty strings in char::to_lowercase. The last column in the lower case table is completely unused. I noticed this table when analyzing code bloat when compiling to wasm. using to_lowercase increased the binary size from 50kb to 75kb (which is mostly consisting of empty entries '\u{0}'). Removing the last column is an obvious solution, two others could be done too. 1. The second column has only one entry. Remove that column and create a special handling for that. 2. Group consecutive chars with the same conversion distance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
///! This file is generated by src/tools/unicode-table-generator; do not edit manually! |
You'll need to modify the table generator tool rather than manually adjusting this file.
ping from triage - can you post your status on this PR? There hasn't been an update in a few months. Thanks! FYI: when a PR is ready for review, send a message containing |
@JohnCSimon I need to edit the table generator instead of the resulting file. I didn't have time yet to do that |
☔ The latest upstream changes (presumably #109216) made this pull request unmergeable. Please resolve the merge conflicts. |
@PSeitz any updates on this? |
@Dylan-DPC It's still on my list, but I didn't have the time yet |
Closing this as inactive. Feel free to reöpen this pr or create a new pr if you get the time to work on this. Thanks |
remove a ton of unused empty strings in
char::to_lowercase
. The last column in the lower case table is completely unused. I noticed this table when analyzing code bloat when compiling to wasm. using to_lowercase increased the binary size from 50kb to 75kb (which is mostly consisting of empty entries '\u{0}').Removing the last column is an obvious solution, two others could be done too.
This changes only internals, public API behavior is unchanged (except probably faster).