Replace nbsp in all rustdoc code blocks #107615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
notriddle
force-pushed
the
notriddle/nbsp
branch
from
6e4e57f to
e721463
Compare
|
Thanks! @bors r+ rollup |
|
📌 Commit e7214631540db696c897616e3d461283be3b3d38 has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
kadiwa4
reviewed
Feb 3, 2023
|
@bors r- |
bors
added
S-waiting-on-author
Co-Authored-By: David Tolnay <dtolnay@gmail.com>
notriddle
force-pushed
the
notriddle/nbsp
branch
from
e721463 to
784665d
Compare
GuillaumeGomez
approved these changes
Feb 3, 2023
|
Thanks! r=me once CI pass. |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added
S-waiting-on-author
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 3, 2023
…mpiler-errors Rollup of 8 pull requests Successful merges: - rust-lang#106887 (Make const/fn return params more suggestable) - rust-lang#107519 (Add type alias for raw OS errors) - rust-lang#107551 ( Replace `ConstFnMutClosure` with const closures ) - rust-lang#107595 (Retry opening proc-macro DLLs a few times on Windows.) - rust-lang#107615 (Replace nbsp in all rustdoc code blocks) - rust-lang#107621 (Intern external constraints in new solver) - rust-lang#107631 (loudly tell people when they change `Cargo.lock`) - rust-lang#107632 (Clarifying that .map() returns None if None.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 8, 2023
…aumeGomez rustdoc: use a newline instead of `<br>` to format code headers Since these elements now use `white-space: pre-wrap` since rust-lang#107615, it's fine to use newlines for formatting, which is smaller and a bit less complicated.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 8, 2023
…aumeGomez rustdoc: use a newline instead of `<br>` to format code headers Since these elements now use `white-space: pre-wrap` since rust-lang#107615, it's fine to use newlines for formatting, which is smaller and a bit less complicated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #106125 by @dtolnay — this PR fixes the line wrapping bug.
Fixes #106098. This makes code copyable from rustdoc rendered documentation into a Rust source file.