Remove OnHit callback from query caches.

[cjgillot]

This is not useful now that query results are Copy.

[rustbot]

r? @estebank

(rustbot has picked a reviewer for you, use r? to override)

[cjgillot]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 128f222 with merge 6bfad8b67b1174cd0b007e584a84abcf80619f6c...

[bors]

☀️ Try build successful - checks-actions
Build commit: 6bfad8b67b1174cd0b007e584a84abcf80619f6c (6bfad8b67b1174cd0b007e584a84abcf80619f6c)

[rust-timer]

Finished benchmarking commit (6bfad8b67b1174cd0b007e584a84abcf80619f6c): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.2%, 0.3%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.3%	[-0.5%, -0.3%]	10
Improvements ✅ (secondary)	-1.8%	[-5.9%, -0.3%]	26
All ❌✅ (primary)	-0.2%	[-0.5%, 0.3%]	12

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.9%	[-4.4%, -3.4%]	4
Improvements ✅ (secondary)	-2.8%	[-6.7%, -1.3%]	44
All ❌✅ (primary)	-3.9%	[-4.4%, -3.4%]	4

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.0%	[2.6%, 3.5%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.4%	[-4.1%, -2.6%]	2
All ❌✅ (primary)	-	-	0

[cjgillot]

As @estebank is temporary out of the review rotation:
r? compiler

[Zoxc]

This looks good to me. The OnHit and OnMiss callbacks existed to better separate hot and cold paths. That isn't relevant anymore since the cold path moved to rustc_query_impl.

[lcnr]

@bors r=lcnr,zoxc

[bors]

📌 Commit 635ff8e has been approved by lcnr,zoxc

It is now in the queue for this repository.

[bors]

⌛ Testing commit 635ff8e with merge edd0d54378f677e9b190669558dc32811bbdad58...

[lcnr]

@bors r=lcnr,Zoxc

[bors]

💡 This pull request was already approved, no need to approve it again.

• This pull request is currently being tested. If there's no response from the continuous integration service, you may use retry to trigger a build again.

[bors]

📌 Commit 635ff8e has been approved by lcnr,Zoxc

It is now in the queue for this repository.

[bors]

⌛ Testing commit 635ff8e with merge e7813fe...

[bors]

☀️ Test successful - checks-actions
Approved by: lcnr,Zoxc
Pushing e7813fe to master...

[rust-timer]

Finished benchmarking commit (e7813fe): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.6%	[-1.7%, -0.2%]	49
Improvements ✅ (secondary)	-2.0%	[-5.9%, -0.3%]	36
All ❌✅ (primary)	-0.6%	[-1.7%, -0.2%]	49

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.2%	[2.2%, 2.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.8%	[-3.2%, -2.3%]	3
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.7%	[2.3%, 2.9%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

[rust-log-analyzer]

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[nnethercote]

FWIW, the post-merge perf run looks better than it should due to some favourable noise: the changes to keccak, cranelift-codegen, and tt-muncher are all just inverses of "regressions" seen in #107627.