Propagate native dynamic libraries/frameworks (plus a few assorted fixes) #10777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // | ||
| // The use case for this is a little subtle. In theory the native | ||
| // dependencies of a crate a purely an implementation detail of the crate | ||
| // itself, but the problem arises with generis and inlined functions. If a |
* Don't flag any address_insignificant statics as reachable because the whole point of the address_insignificant optimization is that the static is not reachable. Additionally, there's no need for it to be reachable because LLVM optimizes it away. * Be sure to not leak external node ids into our reachable set, this can spuriously cause local items to be considered reachable if the node ids just happen to line up
Use the correct set of dependencies as well as CFG_PYTHON instead of assuming 'python' is the right one.
The reasons for this are outlined in issue rust-lang#10743 as well as the comment I have now placed in the code. Closes rust-lang#10743
bors
added a commit
that referenced
this pull request
Dec 3, 2013
Commit messages have the fun details, the focus of this is closing #10743 though
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
May 20, 2023
Enhance `needless_collect`: lint in method/function arguments that take an `IntoIterator` Updates `needless_collect` to also lint `collect` calls in method/function arguments that take an `IntoIterator` (for example `Extend::extend`). Every `Iterator` trivially implements `IntoIterator` and collecting it only causes an unnecessary allocation. --- changelog: Enhancement: [`needless_collect`]: Now also detects function arguments, taking a generic `IntoIterator` [rust-lang#10777](rust-lang/rust-clippy#10777) <!-- changelog_checked --> fixes rust-lang#10762
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit messages have the fun details, the focus of this is closing #10743 though