Add a couple random projection tests for new solver #107855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @lcnr (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
rustbot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
lcnr
reviewed
Feb 10, 2023
| // candidates. | ||
|
|
||
| // We don't unify the RHS of a projection goal eagerly when solving, both | ||
| // for caching reasons and partly, to make sure that we don't make the new |
There was a problem hiding this comment.
Suggested change
| // for caching reasons and partly, to make sure that we don't make the new | |
| // for caching reasons and partly to make sure that we don't make the new |
it feels like there shouldn't be a comma there. Or I guess if it is correct, why? 😅
There was a problem hiding this comment.
No, it was a mistake.
compiler-errors
force-pushed
the
new-solver-random-tests
branch
from
fae90fa to
9790d6f
Compare
|
@bors r=lcnr rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 10, 2023
…tests, r=lcnr Add a couple random projection tests for new solver Self-explanatory, they're just some cases that have been on my mind in the past (especially `tests/ui/traits/new-solver/param-candidate-doesnt-shadow-project.rs`).
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 11, 2023
Rollup of 9 pull requests Successful merges: - rust-lang#105019 (Add parentheses properly for borrowing suggestion) - rust-lang#106001 (Stop at the first `NULL` argument when iterating `argv`) - rust-lang#107098 (Suggest function call on pattern type mismatch) - rust-lang#107490 (rustdoc: remove inconsistently-present sidebar tooltips) - rust-lang#107855 (Add a couple random projection tests for new solver) - rust-lang#107857 (Add ui test for implementation on projection) - rust-lang#107878 (Clarify `new_size` for realloc means bytes) - rust-lang#107888 (revert rust-lang#107074, add regression test) - rust-lang#107900 (Zero the `REPARSE_MOUNTPOINT_DATA_BUFFER` header) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self-explanatory, they're just some cases that have been on my mind in the past (especially
tests/ui/traits/new-solver/param-candidate-doesnt-shadow-project.rs).