Fix a bug in exporting trait implementations #10788
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I used the wrong condition where I was looking for "is this method public or is this implementation a trait" rather than what was being checked.
bors
added a commit
that referenced
this pull request
Dec 4, 2013
I used the wrong condition where I was looking for "is this method public or is this implementation a trait" rather than what was being checked.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 30, 2023
add lint [`incorrect_clone_impl_on_copy_type`] Split off from rust-lang#10788. Closes rust-lang#10700 ---- changelog: new lint [`incorrect_clone_impl_on_copy_type`] [rust-lang#10925](rust-lang/rust-clippy#10925)
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 14, 2023
…impl, r=xFrednet,blyxyas New lint [`manual_partial_ord_and_ord_impl`] Lints when both `PartialOrd` and `Ord` are manually implemented yet the body of `PartialOrd::partial_cmp` isn't `Some(self.cmp(<other>))`. This is in `correctness` currently but I'm ok with elsewhere. Closes rust-lang#10744 --- changelog: new lint [`needless_partial_ord_impl`] [rust-lang#10788](rust-lang/rust-clippy#10788)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used the wrong condition where I was looking for "is this method public or is
this implementation a trait" rather than what was being checked.