Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document PointerLike #107943

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Document PointerLike #107943

merged 1 commit into from
Feb 13, 2023

Conversation

compiler-errors
Copy link
Member

I forgot to document this, and even though it's currently more of an implementation detail, the old doc was kinda embarrassing 😅

@rustbot
Copy link
Collaborator

rustbot commented Feb 12, 2023

r? @scottmcm

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 12, 2023
@rustbot
Copy link
Collaborator

rustbot commented Feb 12, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@jyn514
Copy link
Member

jyn514 commented Feb 12, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 12, 2023

📌 Commit cca82fd has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 12, 2023
@scottmcm
Copy link
Member

Thanks! Even for internal stuff it's nice to have something good on https://stdrs.dev/nightly/x86_64-unknown-linux-gnu/core/marker/trait.PointerLike.html

@compiler-errors compiler-errors mentioned this pull request Feb 12, 2023
Closed
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Feb 12, 2023
@compiler-errors
Rollup merge of rust-lang#107943 - compiler-errors:document-pointer-l…
dcd8e97 
…ike, r=jyn514

Document `PointerLike`

I forgot to document this, and even though it's currently more of an implementation detail, the old doc was kinda embarrassing 😅
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 12, 2023
@matthiaskrgr
Rollup merge of rust-lang#107943 - compiler-errors:document-pointer-l…
6a62471 
…ike, r=jyn514

Document `PointerLike`

I forgot to document this, and even though it's currently more of an implementation detail, the old doc was kinda embarrassing 😅
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 12, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 12, 2023
@matthiaskrgr
Rollup merge of rust-lang#107943 - compiler-errors:document-pointer-l…
cd1b6d0 
…ike, r=jyn514

Document `PointerLike`

I forgot to document this, and even though it's currently more of an implementation detail, the old doc was kinda embarrassing 😅
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 12, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 12, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 12, 2023
@bors
Auto merge of rust-lang#107967 - matthiaskrgr:rollup-7wvbla5, r=matth…
59083c5 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#107748 (refer to new home)
 - rust-lang#107842 (Patch `build/rustfmt/lib/*.so` for NixOS)
 - rust-lang#107930 (Improve JS function itemTypeFromName code a bit)
 - rust-lang#107934 (rustdoc: account for intra-doc links in `<meta name="description">`)
 - rust-lang#107943 (Document `PointerLike`)
 - rust-lang#107954 (avoid mixing accesses of ptrs derived from a mutable ref and parent ptrs)
 - rust-lang#107955 (fix UB in ancient test)
 - rust-lang#107964 (rustdoc: use tighter line height in h1 and h2)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4b91b67 into rust-lang:master Feb 13, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 13, 2023
@compiler-errors compiler-errors deleted the document-pointer-like branch August 11, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@scottmcm scottmcm

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.69.0
Development

Successfully merging this pull request may close these issues.
5 participants
@compiler-errors @rustbot @jyn514 @bors @scottmcm