Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layout: deal with placeholders, ICE on bound types #107986

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Feb 13, 2023

A placeholder type is the same as a param as they represent "this could be any type". A bound type represents a type inside of a for<T> or exists<T>. When entering a forall or exists T should be instantiated as a existential (inference var) or universal (placeholder). You should never observe a bound variable without its binder.

a placeholder type is the same as a param as they
represent "this could be any type". A bound type
represents a type inside of a `for<T>` or `exists<T>`.
When entering a forall or exists `T` should be
instantiated as a existential (inference var) or universal
(placeholder). You should never observe a bound variable
without its binder.
@rustbot
Copy link
Collaborator

rustbot commented Feb 13, 2023

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 13, 2023
@lcnr
Copy link
Contributor Author

lcnr commented Feb 13, 2023

(this causes an ICE in #107981)

@petrochenkov
Copy link
Contributor

This looks reasonable, but I don't have much context here.
Feel free to r- if you need a more qualified review.
@bors r+

@bors
Copy link
Contributor

bors commented Feb 13, 2023

📌 Commit 9e84b00 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 13, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 13, 2023
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#107340 (rustdoc: merge doctest tooltip with notable traits tooltip)
 - rust-lang#107838 (Introduce `-Zterminal-urls` to use OSC8 for error codes)
 - rust-lang#107922 (Print disk usage in PGO CI script)
 - rust-lang#107931 (Intern span when length is MAX_LEN with parent.)
 - rust-lang#107935 (rustc_ast: Merge impls and reorder methods for attributes and meta items)
 - rust-lang#107986 (layout: deal with placeholders, ICE on bound types)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8701e80 into rust-lang:master Feb 13, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 13, 2023
@lcnr lcnr deleted the layout-placeholder branch February 14, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants