Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BasicBlock::new(0) -> START_BLOCK [no functional changes] #108154

Merged
merged 1 commit into from
Feb 17, 2023
Merged

BasicBlock::new(0) -> START_BLOCK [no functional changes] #108154

merged 1 commit into from
Feb 17, 2023

Conversation

scottmcm
Copy link
Member

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Feb 17, 2023

r? @lcnr

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 17, 2023
@rustbot
Copy link
Collaborator

rustbot commented Feb 17, 2023

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@compiler-errors
Copy link
Member

compiler-errors commented Feb 17, 2023 •
edited
Loading

Do you want to also change the usages of BasicBlock::from_{u32,usize} similarly?

Also, there's one usage of Location { block: START_BLOCK, statement_index: 0 } and a few of START_BLOCK.start_location() which can be replaced with Location::START, I think?

@scottmcm
Copy link
Member Author

scottmcm commented Feb 17, 2023 •
edited
Loading

Oh, sure, I can do some more of this. 'Twas just only the new(0) that I noticed, so I looked for more of the same 🙃

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 17, 2023
@scottmcm scottmcm force-pushed the start-block-cleanup branch from 73aa0ec to c946494 Compare February 17, 2023 05:33
@scottmcm
Copy link
Member Author

Didn't find any from_usize(0)s, but hopefully got the rest of them.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 17, 2023
@compiler-errors
Copy link
Member

r=me when green

@scottmcm
Copy link
Member Author

@bors r=compiler-errors

@bors
Copy link
Contributor

bors commented Feb 17, 2023

📌 Commit c946494 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 17, 2023
@scottmcm scottmcm assigned compiler-errors and unassigned lcnr Feb 17, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 17, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 17, 2023
@bors
Auto merge of rust-lang#108159 - matthiaskrgr:rollup-5k2j7cx, r=matth…
f722b24 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#107592 (Default `repr(C)` enums to `c_int` size)
 - rust-lang#107956 (Copy `bin/*` and `lib/*.dylib` files to `stage0-sysroot`)
 - rust-lang#108126 (fix a line, and do a consistency fix)
 - rust-lang#108144 (Add compiler-errors to a few more triagebot groups)
 - rust-lang#108149 (typo)
 - rust-lang#108154 (`BasicBlock::new(0)` -> `START_BLOCK` [no functional changes])

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ae5473c into rust-lang:master Feb 17, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.69.0
Development

Successfully merging this pull request may close these issues.
5 participants
@scottmcm @rustbot @compiler-errors @bors @lcnr