Make query keys Copy

[Zoxc]

This regressed compiler performance locally, so I'm curious what perf will say about it.

Benchmark	Before	After
	Time	Time	%
🟣 clap:check	1.7566s	1.7657s	0.52%
🟣 hyper:check	0.2572s	0.2578s	0.20%
🟣 regex:check	0.9863s	0.9900s	0.37%
🟣 syn:check	1.6018s	1.6073s	0.34%
🟣 syntex_syntax:check	6.2493s	6.2920s	0.68%
Total	10.8512s	10.9127s	0.57%
Summary	1.0000s	1.0042s	0.42%

[rustbot]

r? @compiler-errors

(rustbot has picked a reviewer for you, use r? to override)

[compiler-errors]

@bors try @rust-timer queue

[bors]

⌛ Trying commit f08eb62ee7cc44d8b1d58e1e1eec5cd3d5a523b8 with merge 9c22b17bd3e6c2fe3a1b6bcb05ba469bf3296191...

[Zoxc]

Adding some inline attributes helped:

Benchmark	Before	After
	Time	Time	%
🟣 clap:check	1.7619s	1.7616s	-0.01%
🟣 hyper:check	0.2563s	0.2565s	0.11%
🟣 regex:check	0.9847s	0.9831s	-0.16%
🟣 syn:check	1.5878s	1.5858s	-0.12%
🟣 syntex_syntax:check	6.1293s	6.1229s	-0.10%
Total	10.7199s	10.7099s	-0.09%
Summary	1.0000s	0.9994s	-0.06%

r? @cjgillot

[compiler-errors]

@bors try @rust-timer queue

[bors]

⌛ Trying commit ae9d819177371b1f6038e8f6ae753cd9cc1eb129 with merge 5440299fe26307a7a84dabc1d378b0d64d05931f...

[cjgillot]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 9bfa18c3a00886103f5ca0b4775fd9eb62317dc4 with merge 0218c3d1a786c9070e87cedc809ddad3b1da2f58...

[bors]

☀️ Try build successful - checks-actions
Build commit: 0218c3d1a786c9070e87cedc809ddad3b1da2f58 (0218c3d1a786c9070e87cedc809ddad3b1da2f58)

[rust-timer]

Finished benchmarking commit (0218c3d1a786c9070e87cedc809ddad3b1da2f58): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.6%	[2.6%, 2.6%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	4.0%	[4.0%, 4.0%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	4.0%	[4.0%, 4.0%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

[cjgillot]

Perf does not show any effect, but this changes helps to ensure that we won't have surprises in the future.
Could you:

• remove the extra inline annotations;
• add a comment to explain that the Copy requirement, while not necessary, allows to avoid surprises with potentially expensive cloning.

@bors rollup-
r=me afterwards

[Zoxc]

I would like to see rustc_query_impl bootstrap times as I suspect the functions I put inline(always) were getting inlined previously. Do you know why perf didn't show them? I think a tool that can show changes in inlining behavior would be useful.

[cjgillot]

There appears to be an issue with the perf infra, see the error message on https://perf.rust-lang.org/status.html
I did not attempt to investigate.

[Zoxc]

I added the comment and also verified that the inlining behavior in rustc_query_impl is unchanged. My initial benchmark was noisy for some reason.

[cjgillot]

@bors r+

[bors]

📌 Commit 056c5b3 has been approved by cjgillot

It is now in the queue for this repository.