Move some std tests from tests/ui-fulldeps into library/std

[ChrisDenton]

This allows them to be tested normally along with other ./x test std tests. Moving rename_directory is simple enough but create_dir_all_bare needed to be an std integration test.

Additionally, some tests that I couldn't move atm have instead been placed in an std subdirectory. These tests include ones that do fun things with processes or that intentionally abort the test process.

r? libs

[rustbot]

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

• Stabilizing library features
• Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
• Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
• Changing public documentation in ways that create new stability guarantees
• Changing observable runtime behavior of library APIs

[thomcc]

LGTM

@bors r+

[bors]

📌 Commit 87cd7f8 has been approved by thomcc

It is now in the queue for this repository.

[ChrisDenton]

@bors r-

[matthiaskrgr]

@bors rollup=iffy

[raoulstrackx]

This PR breaks our CI for the SGX platform as file system support is lacking (see sys/sgx/mod.rs:20-21. Using filesystem functions result in:

13:54:01 test create_dir_all_bare ... FAILED
13:54:01 
13:54:01 failures:
13:54:01 
13:54:01 ---- create_dir_all_bare stdout ----
13:54:01 thread 'create_dir_all_bare' panicked at 'called `Result::unwrap()` on an `Err` value: Error { kind: Unsupported, message: "operation not supported on SGX yet" }', library/std/tests/create_dir_all_bare.rs:14:33
13:54:01 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Can we cancel the merge and avoid running such tests on the SGX platform?

[ChrisDenton]

It's already been cancelled. I'll add an exclusion.

[raoulstrackx]

Great! Much appreciated @ChrisDenton !

[the8472]

Additionally, some tests that I couldn't move atm have instead been placed in an std subdirectory. These tests include ones that do fun things with processes or that intentionally abort the test process.

Maybe we could add a [[bin]] to std and calling it from an integration test for those?

[ChrisDenton]

Maybe we could add a [[bin]] to std and calling it from an integration test for those?

Maybe. But I'm not really sure how that would work with the build system.

[thomcc]

My r+ stands, feel free to r=me when ready.

@rustbot author

[ChrisDenton]

@bors r=thomcc

[bors]

📌 Commit 0f221cc has been approved by thomcc

It is now in the queue for this repository.

[bors]

⌛ Testing commit 0f221cc with merge a019e3ef6d28f152af34bedd49dd46bdba9ce82f...

[bors]

💔 Test failed - checks-actions

[ChrisDenton]

@bors retry error building LLVM on i686-mingw-2

This PR should not affect building LLVM in any way.

[bors]

⌛ Testing commit 0f221cc with merge 26c9868...

[bors]

☀️ Test successful - checks-actions
Approved by: thomcc
Pushing 26c9868 to master...

[rust-timer]

Finished benchmarking commit (26c9868): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.3%	[-4.3%, -4.3%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.9%	[1.8%, 2.0%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.1%	[-6.2%, -4.1%]	6
All ❌✅ (primary)	-	-	0