Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ rust-analyzer #108260

Merged
merged 55 commits into from
Feb 20, 2023
Merged

⬆️ rust-analyzer #108260

merged 55 commits into from
Feb 20, 2023

Commits on Jan 11, 2023

  1. Configuration menu
    Copy the full SHA
    3e0e51c View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2023

  1. Configuration menu
    Copy the full SHA
    ae7e62c View commit details
    Browse the repository at this point in the history
  2. Don't trigger postfix completion if block which has an else block

    Discard postfix completion if the next_non_trivia_sibling of dot_token
    is an ELSE_KW.
    dqkqd committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    e1396bd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1be24e0 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2023

  1. Fix active parameter analysis

    Veykril committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    33cacde View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d2cf8c2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9738f97 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2023

  1. Cleanup signature help a bit

    Veykril committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    244a48d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0285acc View commit details
    Browse the repository at this point in the history
  3. ⬆️ rust-analyzer

    lnicola committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    bc45c76 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2023

  1. Support UTF-32 position encoding

    Looks like this is a native encoding for Emacs at least!
    matklad committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    0da2737 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    354b1aa View commit details
    Browse the repository at this point in the history
  3. Auto merge of rust-lang#14143 - lnicola:sync-from-rust, r=lnicola

    minor: sync from downstream
    bors committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    a33e9d9 View commit details
    Browse the repository at this point in the history
  4. Auto merge of rust-lang#14123 - dqkqd:discard-postfix-completion-for-…

    …indivisble-expr, r=Veykril
    
    fix: Don't trigger postfix completion in `if` block which has an `else` block
    
    Fix rust-lang#14096
    bors committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    3812951 View commit details
    Browse the repository at this point in the history
  5. Auto merge of rust-lang#14122 - lowr:patch/abort-macro-expansion-on-o…

    …verflow, r=Veykril
    
    fix: Don't expand macros in the same expansion tree after overflow
    
    This patch fixes 2 bugs:
    
    - In `Expander::enter_expand_id()` (and in code paths it's called), we never check whether we've reached the recursion limit. Although it hasn't been reported as far as I'm aware, this may cause hangs or stack overflows if some malformed attribute macro is used on associated items.
    - We keep expansion even when recursion limit is reached. Take the following for example:
    
      ```rust
      macro_rules! foo { () => {{ foo!(); foo!(); }} }
      fn main() { foo!(); }
      ```
    
      We keep expanding the first `foo!()` in each expansion and would reach the limit at some point, *after which* we would try expanding the second `foo!()` in each expansion until it hits the limit again. This will (by default) lead to ~2^128 expansions.
    
      This is essentially what's happening in rust-lang#14074. Unlike rustc, we don't just stop expanding macros when we fail as long as it produces some tokens so that we can provide completions and other services in incomplete macro calls.
    
    This patch provides a method that takes care of recursion depths (`Expander::within_limit()`) and stops macro expansions in the whole macro expansion tree once it detects recursion depth overflow. To be honest, I'm not really satisfied with this fix because it can still be used in unintended ways to bypass overflow checks, and I'm still seeking ways such that misuses are caught by the compiler by leveraging types or something.
    
    Fixes rust-lang#14074
    bors committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    2a57b01 View commit details
    Browse the repository at this point in the history
  6. Update crates/ide-db/src/line_index.rs

    Co-authored-by: Stig Brautaset <stig@brautaset.org>
    matklad and stig authored Feb 14, 2023
    Configuration menu
    Copy the full SHA
    9fdcf57 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    098d9d7 View commit details
    Browse the repository at this point in the history
  8. refactor: reduce nesting

    lowr committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    60fa8fe View commit details
    Browse the repository at this point in the history
  9. Auto merge of rust-lang#14141 - matklad:utf-32, r=lnicola

    Support UTF-32 position encoding
    
    Looks like this is a native encoding for Emacs at least!
    bors committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    31486a6 View commit details
    Browse the repository at this point in the history
  10. Auto merge of rust-lang#14144 - lowr:fix/find-occurrence-of-raw-ident…

    …, r=Veykril
    
    fix: Search raw identifiers without prefix
    
    When we find references/usages of a raw identifier, we should disregard `r#` prefix because there are keywords one can use without the prefix in earlier editions (see rust-lang#13034; this bug is actually fallout from the PR). `name`, the text we're searching for, has already been stripped of the prefix, but the text of nodes we compare it to hasn't been.
    
    The second commit is strictly refactoring, I can remove it if it's not much of value.
    bors committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    88b3d9f View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    4f6b5f4 View commit details
    Browse the repository at this point in the history
  12. Auto merge of rust-lang#14128 - Veykril:parser, r=Veykril

    internal: Improve parser recovery for delimited lists
    
    Closes rust-lang/rust-analyzer#11188, rust-lang/rust-analyzer#10410, rust-lang/rust-analyzer#10173
    
    Should probably be merged after the stable release as this might get the parser stuck if I missed something
    bors committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    4456800 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    95fa278 View commit details
    Browse the repository at this point in the history
  14. Bump lsp-types

    Veykril committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    38144fd View commit details
    Browse the repository at this point in the history
  15. Auto merge of rust-lang#14147 - Veykril:completion, r=Veykril

    Don't assume VSCode internal commands in the server
    bors committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    2e86029 View commit details
    Browse the repository at this point in the history
  16. Auto merge of rust-lang#14148 - Veykril:lsp-types, r=Veykril

    Bump lsp-types
    bors committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    e7bc68f View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    3c0f20a View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    a18ebf4 View commit details
    Browse the repository at this point in the history
  19. Auto merge of rust-lang#14150 - Veykril:path, r=Veykril

    internal: Don't allocate the generic_args vec in `hir_def::Path` if it consists only of `None` args
    
    Saves roughly 5mb on self
    bors committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    9548388 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    cade9f7 View commit details
    Browse the repository at this point in the history
  21. Auto merge of rust-lang#14151 - Veykril:smallvec, r=Veykril

    internal: Enable smallvec's `union` feature
    bors committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    41db8c2 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    4c2aef6 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    853ae19 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    4aee911 View commit details
    Browse the repository at this point in the history
  25. Auto merge of rust-lang#14149 - Veykril:completion, r=Veykril

    Trigger call info for more completions of signature having things
    bors committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    523fea8 View commit details
    Browse the repository at this point in the history
  26. Auto merge of rust-lang#14152 - Veykril:path-opt, r=Veykril

    Replace some often empty `Vec`s with boxed slices
    bors committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    37608f3 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    bc81d58 View commit details
    Browse the repository at this point in the history
  28. Cargo fmt

    CraftSpider committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    853f047 View commit details
    Browse the repository at this point in the history
  29. Auto merge of rust-lang#14153 - CraftSpider:v7-metadata, r=CraftSpider

    Add v7 metadata support to rust-analyzer
    
    Paired to rust-lang#101550
    bors committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    89b9940 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2023

  1. Fix a pair of typos

    lnicola committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    6e5ec0b View commit details
    Browse the repository at this point in the history
  2. Auto merge of rust-lang#14154 - lnicola:rand-typos, r=lnicola

    minor: Fix a pair of typos
    bors committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    160305b View commit details
    Browse the repository at this point in the history
  3. Simplify

    Veykril committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    026a8c9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    23fc596 View commit details
    Browse the repository at this point in the history
  5. Auto merge of rust-lang#14156 - Veykril:completion-pod, r=Veykril

    internal: Don't reconstruct ref match completion in to_proto manually
    
    cc rust-lang/rust-analyzer#12571
    bors committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    a04054a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    5859190 View commit details
    Browse the repository at this point in the history
  7. Auto merge of rust-lang#14157 - Veykril:inlay, r=Veykril

    Adjust binding mode inlay hints to render better with @ patterns
    bors committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    dd582da View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    e550e55 View commit details
    Browse the repository at this point in the history
  9. Auto merge of rust-lang#14160 - Veykril:hover-call, r=Veykril

    fix: Bring back hovering call parens for return type info
    bors committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    1f2d33f View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    a6f54d6 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2023

  1. Auto merge of rust-lang#14162 - azriel91:bugfix/14161/generate-getter…

    …-snippet-cap-check, r=Veykril
    
    Conditionally add snippet marker.
    
    Fixes rust-lang#14161.
    
    Heya, I just added the code with some tests, but not sure if it's *the way* to do it -- I didn't refactor existing methods for the `check` test method, but added another calling layer.
    bors committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    d011e79 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    404a51f View commit details
    Browse the repository at this point in the history
  3. Auto merge of rust-lang#14165 - Veykril:completion-item, r=Veykril

    internal: Make CompletionItem more POD-like
    bors committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    b881deb View commit details
    Browse the repository at this point in the history
  4. fix link

    Ethan-000 authored Feb 16, 2023
    Configuration menu
    Copy the full SHA
    936bac3 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a6603fc View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2023

  1. ⬆️ rust-analyzer

    lnicola committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    03288eb View commit details
    Browse the repository at this point in the history