rustdoc: Fix duplicated attributes for first reexport #108310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
notriddle
reviewed
Feb 21, 2023
Comment on lines
+2136
to
+2137
| // In case the "parent" is the crate, it'll give `Res::Err` so we need to | ||
| // circumvent it this way. |
There was a problem hiding this comment.
This looks like a workaround for a compiler bug. Is it, or is it supposed to work this way?
There was a problem hiding this comment.
I think it's supposed to work this way. Just a bit surprising.
GuillaumeGomez
force-pushed
the
fix-reexports-duplicated-attributes
branch
from
3177cff to
8eb1af2
Compare
|
Updated! |
notriddle
reviewed
Feb 21, 2023
GuillaumeGomez
force-pushed
the
fix-reexports-duplicated-attributes
branch
from
8eb1af2 to
fec6ad6
Compare
|
Updated! |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 22, 2023
…cated-attributes, r=notriddle rustdoc: Fix duplicated attributes for first reexport Fixes rust-lang#108281. r? `@notriddle`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 22, 2023
…llaumeGomez Rollup of 8 pull requests Successful merges: - rust-lang#108110 (Move some `InferCtxt` methods to `EvalCtxt` in new solver) - rust-lang#108168 (Fix ICE on type alias in recursion) - rust-lang#108230 (Convert a hard-warning about named static lifetimes into lint "unused_lifetimes") - rust-lang#108239 (Fix overlapping spans in removing extra arguments) - rust-lang#108246 (Add an InstCombine for redundant casts) - rust-lang#108264 (no-fail-fast support for tool testsuites) - rust-lang#108310 (rustdoc: Fix duplicated attributes for first reexport) - rust-lang#108318 (Remove unused FileDesc::get_cloexec) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #108281.
r? @notriddle