Lint dead code in closures and generators #108315
Merged
+39
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @cjgillot (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
clubby789
force-pushed
the
dead-code-in-closure
branch
from
7129363 to
f84f831
Compare
|
Adding lints or making them catch more things is never a breaking change. They do require an FCP if big enough but this is just a small fix to restore previous behavior and should therefore be able to just go through. |
clubby789
changed the title
clubby789
force-pushed
the
dead-code-in-closure
branch
from
f84f831 to
b2c43b7
Compare
clubby789
force-pushed
the
dead-code-in-closure
branch
from
b2c43b7 to
c7a4f38
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 22, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#107736 ( Rename atomic 'as_mut_ptr' to 'as_ptr' to match Cell (ref rust-lang#66893) ) - rust-lang#108176 (Don't delay `ReError` bug during lexical region resolve) - rust-lang#108315 (Lint dead code in closures and generators) - rust-lang#108342 (apply query response: actually define opaque types) - rust-lang#108344 (Fix test filename for rust-lang#105700) - rust-lang#108353 (resolve: Remove `ImportResolver`) Failed merges: - rust-lang#107911 (Add check for invalid #[macro_export] arguments) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #108296
I think this might be a potentially breaking change, but restores the behaviour of pre-1.64.
@rustbot label +A-lint