Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make match arm comma suggestion more clear #108477

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

y21
Copy link
Member

@y21 y21 commented Feb 26, 2023

Fixes #108472

@rustbot
Copy link
Collaborator

rustbot commented Feb 26, 2023

r? @jackh726

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 26, 2023
@y21 y21 force-pushed the replace-semi-with-comma-sugg branch from 8da8d14 to 32da026 Compare February 26, 2023 11:00
@compiler-errors
Copy link
Member

r? @compiler-errors @bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 26, 2023

📌 Commit 32da026 has been approved by compiler-errors

It is now in the queue for this repository.

@rustbot rustbot assigned compiler-errors and unassigned jackh726 Feb 26, 2023
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 26, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 26, 2023
…r=compiler-errors

Make `match` arm comma suggestion more clear

Fixes rust-lang#108472
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Feb 26, 2023
…r=compiler-errors

Make `match` arm comma suggestion more clear

Fixes rust-lang#108472
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Feb 26, 2023
…r=compiler-errors

Make `match` arm comma suggestion more clear

Fixes rust-lang#108472
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 27, 2023
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#108319 (Don't project specializable RPITIT projection)
 - rust-lang#108364 (Unify validity checks into a single query)
 - rust-lang#108463 (bootstrap: Update the output of the `check` descriptions)
 - rust-lang#108477 (Make `match` arm comma suggestion more clear)
 - rust-lang#108486 (Merge diagnostic_items duplicate diagnostics)
 - rust-lang#108494 (Clean up JS files code a bit)
 - rust-lang#108500 (update Miri)
 - rust-lang#108502 (Don't trigger error for ReError when other region is empty.)
 - rust-lang#108513 (Remove `@nagisa` from review rotation)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 69b1b94 into rust-lang:master Feb 27, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve match arm with semi-colon help suggestion
6 participants