Properly colorize multi-part suggestions in the same line #108627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Nilstrieb (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
WaffleLapkin
approved these changes
Mar 2, 2023
|
r? @WaffleLapkin |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 2, 2023
…WaffleLapkin Properly colorize multi-part suggestions in the same line Fix rust-lang#108547.
|
@bors r- failed in a rollup |
bors
added
S-waiting-on-author
|
@matthiaskrgr Oh no, it is because windows uses a different palette from linux and mac 🤦 I'll make it ignore windows for now. |
estebank
force-pushed
the
suggestion-hightlight
branch
from
3cea838 to
6fd1751
Compare
|
@bors r=WaffleLapkin |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 4, 2023
…WaffleLapkin Properly colorize multi-part suggestions in the same line Fix rust-lang#108547.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 4, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#108627 (Properly colorize multi-part suggestions in the same line) - rust-lang#108632 (Omit unchanged options from config.toml in `configure.py`) - rust-lang#108715 (Remove unclosed_delims from parser) - rust-lang#108723 (rustdoc: function signature search with traits in `where` clause) - rust-lang#108724 (field is not used outside the crate) - rust-lang#108734 (rustdoc: Note in a type's layout/size if it is uninhabited) - rust-lang#108736 (Remove `allow(potential_query_instability)` from `ast_passes`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #108547.