Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[experiment] monomorphize fewer items in rustc_query_impl #108643

Closed
wants to merge 2 commits into from
Closed

[experiment] monomorphize fewer items in rustc_query_impl #108643

wants to merge 2 commits into from

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Mar 2, 2023 •
edited
Loading

Helps with #65031.

r? @ghost

@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 2, 2023
@jyn514
Copy link
Member Author

jyn514 commented Mar 2, 2023

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 2, 2023
@bors
Copy link
Contributor

bors commented Mar 2, 2023

⌛ Trying commit 268434407be7b4a879635e2261ea0e974ca21297 with merge 0685064adc558d4896fd029045362190fc48d989...

@bors
Copy link
Contributor

bors commented Mar 2, 2023

☀️ Try build successful - checks-actions
Build commit: 0685064adc558d4896fd029045362190fc48d989 (0685064adc558d4896fd029045362190fc48d989)

1 similar comment
@bors
Copy link
Contributor

bors commented Mar 2, 2023

☀️ Try build successful - checks-actions
Build commit: 0685064adc558d4896fd029045362190fc48d989 (0685064adc558d4896fd029045362190fc48d989)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0685064adc558d4896fd029045362190fc48d989): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.6% [0.2%, 1.2%] 107
Regressions ❌
(secondary)		 0.8% [0.1%, 2.0%] 56
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.6% [0.2%, 1.2%] 107

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.4% [1.4%, 1.4%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -4.7% [-4.7%, -4.7%] 1
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.7% [0.7%, 0.7%] 1
Regressions ❌
(secondary)		 1.7% [1.4%, 2.1%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.7% [0.7%, 0.7%] 1

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Mar 2, 2023
@jyn514
don't monomorphize with_anon_task for each query
9d40b09
@jyn514
Separate out a load_from_disk_and_cache_in_memory function that can…
8db1c97 
… be monomorphized fewer times

```
{"name":"rustc_query_system::query::plumbing::load_from_disk_and_cache_in_memory","total_estimate":53295,"instantiation_count":187}
{"name":"rustc_query_system::query::plumbing::try_load_from_disk_and_cache_in_memory","total_estimate":65340,"instantiation_count":297}
{"name":"rustc_query_system::query::plumbing::execute_job","total_estimate":124146,"instantiation_count":297}
```
@jyn514
Copy link
Member Author

jyn514 commented Mar 9, 2023

Giving up on 2684344 for now, #108167 broke it pretty badly :/

@jyn514
Copy link
Member Author

jyn514 commented Mar 9, 2023

Trying this again after #108167 and without #106311 mixed in.

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Mar 9, 2023

⌛ Trying commit 8db1c97 with merge d562a496f7a126a3355fb69fb52681fb8866d672...

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 9, 2023
@bors
Copy link
Contributor

bors commented Mar 9, 2023

☀️ Try build successful - checks-actions
Build commit: d562a496f7a126a3355fb69fb52681fb8866d672 (d562a496f7a126a3355fb69fb52681fb8866d672)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d562a496f7a126a3355fb69fb52681fb8866d672): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.0% [1.0%, 1.0%] 1
Improvements ✅
(primary)		 -4.1% [-7.1%, -2.9%] 8
Improvements ✅
(secondary)		 -2.5% [-4.7%, -0.8%] 109
All ❌✅ (primary) -4.1% [-7.1%, -2.9%] 8

Cycles

This benchmark run did not return any relevant results for this metric.

@rustbot rustbot removed S-waiting-on-perf Status: Waiting on a perf run to be completed. perf-regression Performance regression. labels Mar 9, 2023
@jyn514 jyn514 closed this Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jyn514 @rust-timer @bors @rustbot