-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cargo #108665
Update cargo #108665
Conversation
|
These commits modify the If this was intentional then you can ignore this comment. Some changes occurred in src/tools/cargo cc @ehuss |
@bors rollup=never |
I reached out to the compiler team to look at the dependency update for It looks like it introduces a new warning in |
This comment has been minimized.
This comment has been minimized.
@ehuss This is ready for a second round of review. I hope the fix looks fine. |
@bors r+ p=1 |
📌 Commit b51d127bb02b76ece6de30a2dba98e8502ab4cae has been approved by It is now in the queue for this repository. |
⌛ Testing commit b51d127bb02b76ece6de30a2dba98e8502ab4cae with merge aaa448d5735672b51256df9283469b4ed9887938... |
💔 Test failed - checks-actions |
It appears to be a problem with rustix containing references to |
I've now released rustix 0.36.9 with a fix for the |
@sunfishcode thanks for the quick patch! I'll go ahead and merge it. Please shout out if you think it is wrong. @bors r+ p=1 rollup=never |
📌 Commit e22675fd186a5d09cfca2690e0e7ee3cfdff402b has been approved by It is now in the queue for this repository. |
This comment has been minimized.
This comment has been minimized.
Now rust-lang/cargo#11738 is reverted. |
⌛ Trying commit 2fc970321353d3677952cb219e728c44fd47c71c with merge 62c208e611d34224f83b96ca5b49e8a43c72096a... |
☀️ Try build successful - checks-actions |
☀️ Test successful - checks-actions |
Finished benchmarking commit (900c354): comparison URL. Overall result: ❌ regressions - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This looks quite likely to be noise, so marking as triaged. |
…ehuss Make cargo a workspace 8 commits in 7bf43f028ba5eb1f4d70d271c2546c38512c9875..39116ccc9b420a883a98a960f0597f9cf87414b8 2023-04-10 16:01:41 +0000 to 2023-04-15 20:24:15 +0000 - Make cargo a workspace (rust-lang/cargo#11851) - Fix flaky not_found_permutations test. (rust-lang/cargo#11976) - Use restricted Damerau-Levenshtein algorithm (rust-lang/cargo#11963) - Correct the bug report for `cargo clippy --fix` (rust-lang/cargo#11882) - Stabilize `cargo logout` (rust-lang/cargo#11950) - Add more information to HTTP errors to help with debugging. (rust-lang/cargo#11878) - Use registry.default for login/logout (rust-lang/cargo#11949) - Change -C to be unstable (rust-lang/cargo#11960) --- ### What does this PR try to resolve? Making cargo a workspace. Why doing this? * `rustc-workspace-hack` is primarily for sharing dependencies between rls and cargo, as rls previously depends on cargo. After rls retired, it is no longer the case sharing dependencies. * It's q bit painful that cargo needs to deal with some dependency and licensing complexities. For example, rust-lang#108665 failed because of the interaction bewteen `windows-sys` and `raw-dylib`. It currenctly blocks cargo's feature `-Zgitxodie` from moving forward. * See rust-lang/cargo#11851 ### Benchmark result I've done a simple benchmark on both keeping or removing entire `rustc-workspace-hack`. It had no significant difference. Both took ~2m30s to finish `./x.py build -j8 src/tools/cargo src/tools/rls src/tools/clippy src/tools/miri src/tools/rustfmt`. Environment info: ``` host: aarch64-apple-darwin os: Mac OS 13.2.1 [64-bit] ``` A sophisticated benchmark may be needed. ### Additional information This depends on prior works from `@Muscraft` and `@ehuss.` Credits to them!
Update windows-sys This updates the windows-sys dependency from 0.45 to 0.48. This shouldn't add or remove any duplicate dependencies (since there are other dependencies still using 0.45 and 0.42). The intent is to move it along the direction towards unifying in the future (though it seems like a moving target that will be difficult to ever hit). This also bumps the home crate version. I think it should be OK to make the migration from winapi to windows-sys a patch version, though there seems to be some issues with the way windows-sys works that could introduce some build-time problems in some situations (such as those encountered in rust-lang/rust#108665 and rust-lang/rust#106610). However, I don't expect too much of an issue.
25 commits in 9880b408a3af50c08fab3dbf4aa2a972df71e951..7d3033d2e59383fd76193daf9423c3d141972a7d
2023-02-28 19:39:39 +0000 to 2023-03-08 17:05:08 +0000
CARGO_PKG_README
(AddCARGO_PKG_README
cargo#11645)CARGO_CFG_
vars for configs defined both with and without value (FixCARGO_CFG_
vars for configs defined both with and without value cargo#11790)sparse
the default protocol for crates.io (Makesparse
the default protocol for crates.io cargo#11791)-Zdirect-minimal-versions
(feat(resolver):-Zdirect-minimal-versions
cargo#11688)This update is primarily for making rust-lang/cargo#11630 into 1.69(will file a beta backport then). However, just look into the licenses and dependencies permitted list, it looks a bit unfortunate but inevitable I guess?r? @ehuss
cc @Muscraft