Match unmatched backticks in compiler/ comments #108694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-query-system
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
est31
force-pushed
the
backticks_matchmaking_comments
branch
from
374fe75 to
6df5ae4
Compare
|
@bors r+ |
|
🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened. |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 3, 2023
…ts, r=Nilstrieb Match unmatched backticks in compiler/ comments r? `@Nilstrieb` as per [advice](rust-lang#108685 (comment))
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 3, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#107981 (new solver: implement canonicalization and region constraints) - rust-lang#108553 (Deny capturing late-bound non-lifetime param in anon const) - rust-lang#108599 (Remove legacy PM leftovers) - rust-lang#108667 (Fix another ICE in `point_at_expr_source_of_inferred_type`) - rust-lang#108674 (Clippy Fix array-size-threshold config deserialization error) - rust-lang#108685 (Match unmatched backticks in compiler/) - rust-lang#108694 (Match unmatched backticks in compiler/ comments) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 12, 2023
…r=Nilstrieb tidy: enforce comment blocks to have an even number of backticks After PR rust-lang#108694, most unmatched backticks in `compiler/` comments have been eliminated. This PR adds a tidy lint to ensure no new unmatched backticks are added, and either addresses the lint in the remaining instances it found, or allows it. Very often, backtick containing sections wrap around lines, for example: ```Rust // This function takes a tuple `(Vec<String>, // Box<[u8]>)` and transforms it into `Vec<u8>`. ``` The lint is implemented to work on top of blocks, counting each line with a `//` into a block, and counting if there are an odd or even number of backticks in the entire block, instead of looking at just a single line.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 12, 2023
…r=Nilstrieb tidy: enforce comment blocks to have an even number of backticks After PR rust-lang#108694, most unmatched backticks in `compiler/` comments have been eliminated. This PR adds a tidy lint to ensure no new unmatched backticks are added, and either addresses the lint in the remaining instances it found, or allows it. Very often, backtick containing sections wrap around lines, for example: ```Rust // This function takes a tuple `(Vec<String>, // Box<[u8]>)` and transforms it into `Vec<u8>`. ``` The lint is implemented to work on top of blocks, counting each line with a `//` into a block, and counting if there are an odd or even number of backticks in the entire block, instead of looking at just a single line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Nilstrieb as per advice